[asterisk-dev] [Code Review] 2376: Adding RESTful API's to Asterisk

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2376/
-----------------------------------------------------------

(Updated April 1, 2013, 4:01 p.m.)


Review request for Asterisk Developers.


Changes
-------

I just realized that this review hasn't been updated in weeks. Sorry
about that!

 * Merged latest from stasis-app
 * Addressed mjordan's review feedback
 * Implemented several more of the HTTP handlers for channels
 * Implemented CORS spec for accessing stasis-http
 * Merged kharwell's configuration patch


Repository: Asterisk


Description
-------

This patch represents the first step toward adding a RESTful API to Asterisk.

The following is the file doc from res_stasis_http.c:

The API itself is documented using Swagger[1], a lightweight mechanism for
documenting RESTful API's using JSON. This allows us to use swagger-ui[2] to
provide executable documentation for the API, generate client bindings in
different languages[3], and generate a lot of the boilerplate code for
implementing the RESTful bindings. The API docs live in the rest-api/ directory.

The RESTful bindings are generated from the Swagger API docs using a set of
Cog.py[4] templates. Cog.py is extemely lightweight (maybe too lightweight), and
can be installed easily using pip. Template scripts live in the cog/ directory,
and the generated code lives in the res/stasis-http/ directory.

The structure of the generated code is:

 - A tree of stasis_rest_handlers which are used for request routing.
 - Prototypes for request handlers, and structures for passing arguments in
   the request handler.
 - A set of stasis_rest_callback functions, which glue the two
   together. They parse out path variables and request parameters to populate
   a specific *_args which is passed to the specific request handler.

The use of the generated *_args allows for greater type safety and reduced
boilerplate in the request handlers themselves.

The basic flow of an HTTP request is:

 - stasis_http_callback()
   1. Initial request validation
   2. Routes as either a doc request (stasis_http_get_docs) or API
      request (stasis_http_invoke)
      - stasis_http_invoke()
        1. Further request validation
        2. Routes the request through the tree of generated
           stasis_rest_handlers.
        3. Dispatch to the generated callback
           - stasis_http_*_cb
             1. Populate *_args struct with path and get params
             2. Invoke the request handler
   3. Validates and sends response

 [1]: https://developers.helloreverb.com/swagger/
 [2]: https://github.com/wordnik/swagger-ui
 [3]: https://github.com/asterisk/asterisk_rest_libraries
 [4]: http://nedbatchelder.com/code/cog/


Diffs (updated)
-----

  /team/dlee/stasis-app/configs/stasis_http.conf.sample PRE-CREATION 
  /team/dlee/stasis-app/cog/stasis_http_resources.c.cog PRE-CREATION 
  /team/dlee/stasis-app/cog/stasis_http_resource.h.cog PRE-CREATION 
  /team/dlee/stasis-app/cog/stasis_http_resource.c.cog PRE-CREATION 
  /team/dlee/stasis-app/cog/stasis_cog.py PRE-CREATION 
  /team/dlee/stasis-app/cog/res_stasis_http.make.cog PRE-CREATION 
  /team/dlee/stasis-app/cog/odict.py PRE-CREATION 
  /team/dlee/stasis-app/build_tools/make_stasis_http_stubs PRE-CREATION 
  /team/dlee/stasis-app/apps/app_stasis.c 384510 
  /team/dlee/stasis-app/Makefile 384510 
  /team/dlee/stasis-app/include/asterisk/app_stasis.h 384510 
  /team/dlee/stasis-app/include/asterisk/http.h 384510 
  /team/dlee/stasis-app/include/asterisk/json.h 384510 
  /team/dlee/stasis-app/include/asterisk/stasis_http.h PRE-CREATION 
  /team/dlee/stasis-app/include/asterisk/strings.h 384510 
  /team/dlee/stasis-app/include/asterisk/utils.h 384510 
  /team/dlee/stasis-app/main/http.c 384510 
  /team/dlee/stasis-app/main/json.c 384510 
  /team/dlee/stasis-app/res/Makefile 384510 
  /team/dlee/stasis-app/res/res_stasis_http.c PRE-CREATION 
  /team/dlee/stasis-app/res/res_stasis_http.exports.in PRE-CREATION 
  /team/dlee/stasis-app/res/res_stasis_http.make PRE-CREATION 
  /team/dlee/stasis-app/res/stasis_http/resource_asterisk.h PRE-CREATION 
  /team/dlee/stasis-app/res/stasis_http/resource_asterisk.c PRE-CREATION 
  /team/dlee/stasis-app/res/stasis_http/resource_bridges.h PRE-CREATION 
  /team/dlee/stasis-app/res/stasis_http/resource_bridges.c PRE-CREATION 
  /team/dlee/stasis-app/res/stasis_http/resource_channels.h PRE-CREATION 
  /team/dlee/stasis-app/res/stasis_http/resource_channels.c PRE-CREATION 
  /team/dlee/stasis-app/res/stasis_http/resource_endpoints.h PRE-CREATION 
  /team/dlee/stasis-app/res/stasis_http/resource_endpoints.c PRE-CREATION 
  /team/dlee/stasis-app/res/stasis_http/resource_events.h PRE-CREATION 
  /team/dlee/stasis-app/res/stasis_http/resource_events.c PRE-CREATION 
  /team/dlee/stasis-app/res/stasis_http/resource_recordings.h PRE-CREATION 
  /team/dlee/stasis-app/res/stasis_http/resource_recordings.c PRE-CREATION 
  /team/dlee/stasis-app/res/stasis_http/resources.c PRE-CREATION 
  /team/dlee/stasis-app/rest-api/README.txt PRE-CREATION 
  /team/dlee/stasis-app/rest-api/asterisk.json PRE-CREATION 
  /team/dlee/stasis-app/rest-api/bridges.json PRE-CREATION 
  /team/dlee/stasis-app/rest-api/channels.json PRE-CREATION 
  /team/dlee/stasis-app/rest-api/endpoints.json PRE-CREATION 
  /team/dlee/stasis-app/rest-api/events.json PRE-CREATION 
  /team/dlee/stasis-app/rest-api/recordings.json PRE-CREATION 
  /team/dlee/stasis-app/rest-api/resources.json PRE-CREATION 
  /team/dlee/stasis-app/tests/test_stasis.c 384510 
  /team/dlee/stasis-app/tests/test_stasis_http.c PRE-CREATION 
  /team/dlee/stasis-app/tests/test_strings.c 384510 

Diff: https://reviewboard.asterisk.org/r/2376/diff/


Testing
-------

Unit tests


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130401/cb3d2baf/attachment-0001.htm>