<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2376/">https://reviewboard.asterisk.org/r/2376/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated April 1, 2013, 4:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just realized that this review hasn't been updated in weeks. Sorry
about that!
* Merged latest from stasis-app
* Addressed mjordan's review feedback
* Implemented several more of the HTTP handlers for channels
* Implemented CORS spec for accessing stasis-http
* Merged kharwell's configuration patch
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch represents the first step toward adding a RESTful API to Asterisk.
The following is the file doc from res_stasis_http.c:
The API itself is documented using Swagger[1], a lightweight mechanism for
documenting RESTful API's using JSON. This allows us to use swagger-ui[2] to
provide executable documentation for the API, generate client bindings in
different languages[3], and generate a lot of the boilerplate code for
implementing the RESTful bindings. The API docs live in the rest-api/ directory.
The RESTful bindings are generated from the Swagger API docs using a set of
Cog.py[4] templates. Cog.py is extemely lightweight (maybe too lightweight), and
can be installed easily using pip. Template scripts live in the cog/ directory,
and the generated code lives in the res/stasis-http/ directory.
The structure of the generated code is:
- A tree of stasis_rest_handlers which are used for request routing.
- Prototypes for request handlers, and structures for passing arguments in
the request handler.
- A set of stasis_rest_callback functions, which glue the two
together. They parse out path variables and request parameters to populate
a specific *_args which is passed to the specific request handler.
The use of the generated *_args allows for greater type safety and reduced
boilerplate in the request handlers themselves.
The basic flow of an HTTP request is:
- stasis_http_callback()
1. Initial request validation
2. Routes as either a doc request (stasis_http_get_docs) or API
request (stasis_http_invoke)
- stasis_http_invoke()
1. Further request validation
2. Routes the request through the tree of generated
stasis_rest_handlers.
3. Dispatch to the generated callback
- stasis_http_*_cb
1. Populate *_args struct with path and get params
2. Invoke the request handler
3. Validates and sends response
[1]: https://developers.helloreverb.com/swagger/
[2]: https://github.com/wordnik/swagger-ui
[3]: https://github.com/asterisk/asterisk_rest_libraries
[4]: http://nedbatchelder.com/code/cog/
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/dlee/stasis-app/configs/stasis_http.conf.sample <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/cog/stasis_http_resources.c.cog <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/cog/stasis_http_resource.h.cog <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/cog/stasis_http_resource.c.cog <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/cog/stasis_cog.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/cog/res_stasis_http.make.cog <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/cog/odict.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/build_tools/make_stasis_http_stubs <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/apps/app_stasis.c <span style="color: grey">(384510)</span></li>
<li>/team/dlee/stasis-app/Makefile <span style="color: grey">(384510)</span></li>
<li>/team/dlee/stasis-app/include/asterisk/app_stasis.h <span style="color: grey">(384510)</span></li>
<li>/team/dlee/stasis-app/include/asterisk/http.h <span style="color: grey">(384510)</span></li>
<li>/team/dlee/stasis-app/include/asterisk/json.h <span style="color: grey">(384510)</span></li>
<li>/team/dlee/stasis-app/include/asterisk/stasis_http.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/include/asterisk/strings.h <span style="color: grey">(384510)</span></li>
<li>/team/dlee/stasis-app/include/asterisk/utils.h <span style="color: grey">(384510)</span></li>
<li>/team/dlee/stasis-app/main/http.c <span style="color: grey">(384510)</span></li>
<li>/team/dlee/stasis-app/main/json.c <span style="color: grey">(384510)</span></li>
<li>/team/dlee/stasis-app/res/Makefile <span style="color: grey">(384510)</span></li>
<li>/team/dlee/stasis-app/res/res_stasis_http.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/res/res_stasis_http.exports.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/res/res_stasis_http.make <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/res/stasis_http/resource_asterisk.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/res/stasis_http/resource_asterisk.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/res/stasis_http/resource_bridges.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/res/stasis_http/resource_bridges.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/res/stasis_http/resource_channels.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/res/stasis_http/resource_channels.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/res/stasis_http/resource_endpoints.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/res/stasis_http/resource_endpoints.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/res/stasis_http/resource_events.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/res/stasis_http/resource_events.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/res/stasis_http/resource_recordings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/res/stasis_http/resource_recordings.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/res/stasis_http/resources.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/rest-api/README.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/rest-api/asterisk.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/rest-api/bridges.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/rest-api/channels.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/rest-api/endpoints.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/rest-api/events.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/rest-api/recordings.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/rest-api/resources.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/tests/test_stasis.c <span style="color: grey">(384510)</span></li>
<li>/team/dlee/stasis-app/tests/test_stasis_http.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/stasis-app/tests/test_strings.c <span style="color: grey">(384510)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2376/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>