[asterisk-dev] [JIRA] Closed: (ASTERISK-17367) [patch] AGI streamfile turns off moh, doesn't turn it on

[Olle E. Johansson]

27 sep 2012 kl. 19:43 skrev Joshua Colp (JIRA) <noreply at issues.asterisk.org>:

> 
>     [ https://issues.asterisk.org/jira/browse/ASTERISK-17367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> 
> Joshua Colp closed ASTERISK-17367.
> ----------------------------------
> 
>    Resolution: Won't Fix
> 
> After reading the existing code, the patch, and the discussions that occurred as a result of this I have determined that changing the behavior is not warranted. Stopping music on hold within streamfile is done as a precaution to ensure it can play the file. It is not designed or expected to restore the state of the world to what it was to this degree. This can be accomplished in the AGI by calling set music before playing the file.
> 
> If there are situations where this is not possible I am completely willing to discuss them and re-evaluate my decision.


Josh, 
I don't agree - in many other parts of Asterisk - and in the AGI - we turn generators on after we're done with the requested operation. I think that should be the default. If not, you will have to add documentation that clearly CLEARLY states that the AGI streamfile command turns off music on hold and it will stay off.

/O

> 
>> [patch] AGI streamfile turns off moh, doesn't turn it on
>> --------------------------------------------------------
>> 
>>                Key: ASTERISK-17367
>>                URL: https://issues.asterisk.org/jira/browse/ASTERISK-17367
>>            Project: Asterisk
>>         Issue Type: Bug
>>         Components: Resources/res_agi
>>           Reporter: Olle Johansson
>>           Severity: Minor
>>        Attachments: 18768.diff
>> 
>> 
>> The AGI streamfile command turns off music on hold before streaming a file, but it is never turned on again. I consider this a bug.
>> I have a patch for this, but since this behaviour has existed for a long time - should we add a config variable somewhere to turn this "correct" behaviour on, in order not to mess up existing applications? If so, in which file?
>> ****** ADDITIONAL INFORMATION ******
>> Found the issue in 1.4
> 
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira