[asterisk-dev] [Code Review] dsp.c: in ast_mf_detect_init incorrectly sets goertzel samples to 160, should be 120, or better MF_GSIZE

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2097/#review7018
-----------------------------------------------------------

Ship it!


This improvement should really only be done in trunk.

- rmudgett


On Sept. 5, 2012, 4:44 a.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2097/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2012, 4:44 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Replace magic number 160 with MF_GSIZE.
> 
> however the 'samples' member of goertzel_state_t is never used.
> 
> 
> Diffs
> -----
> 
>   trunk/main/dsp.c 372242 
> 
> Diff: https://reviewboard.asterisk.org/r/2097/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120905/83a287f7/attachment.htm>