[asterisk-dev] [Code Review] dsp.c: in ast_mf_detect_init incorrectly sets goertzel samples to 160, should be 120, or better MF_GSIZE

Alec Davis reviewboard at asterisk.org
Wed Sep 5 04:44:23 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2097/
-----------------------------------------------------------

(Updated Sept. 5, 2012, 4:44 a.m.)


Review request for Asterisk Developers.


Changes
-------

remove unused goertzel_state_t member 'samples'.

Compiles.


Summary
-------

Replace magic number 160 with MF_GSIZE.

however the 'samples' member of goertzel_state_t is never used.


Diffs (updated)
-----

  trunk/main/dsp.c 372242 

Diff: https://reviewboard.asterisk.org/r/2097/diff


Testing
-------


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120905/429c9520/attachment.htm>


More information about the asterisk-dev mailing list