[asterisk-dev] [Code Review] Fix for chan_skinny leaving RTP ports open

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2176/#review7344
-----------------------------------------------------------

Ship it!


This looks good by me.

- Mark


On Oct. 31, 2012, 2:30 a.m., wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2176/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2012, 2:30 a.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Summary
> -------
> 
> Skinny wasn't closing RTP sockets. This patch includes ast_rtp_instance_stop before ast_rtp_instance_destroy which fixes the problem. Also add destroy for VRTP (which I believe is unused, but exists). Also removed some blobs.
> 
> Not sure, but maybe ast_rtp_instance_destroy should first stop the RTP which would make this patch redundant.
> 
> 
> Diffs
> -----
> 
>   /branches/11/channels/chan_skinny.c 375469 
> 
> Diff: https://reviewboard.asterisk.org/r/2176/diff
> 
> 
> Testing
> -------
> 
> Made a couple of calls and netstat'd the ports. All closed at end of call.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121031/968e6f08/attachment.htm>