[asterisk-dev] [Code Review] Fix for chan_skinny leaving RTP ports open

wedhorn reviewboard at asterisk.org
Wed Oct 31 02:30:38 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2176/
-----------------------------------------------------------

Review request for Asterisk Developers and Matt Jordan.


Summary
-------

Skinny wasn't closing RTP sockets. This patch includes ast_rtp_instance_stop before ast_rtp_instance_destroy which fixes the problem. Also add destroy for VRTP (which I believe is unused, but exists). Also removed some blobs.

Not sure, but maybe ast_rtp_instance_destroy should first stop the RTP which would make this patch redundant.


Diffs
-----

  /branches/11/channels/chan_skinny.c 375469 

Diff: https://reviewboard.asterisk.org/r/2176/diff


Testing
-------

Made a couple of calls and netstat'd the ports. All closed at end of call.


Thanks,

wedhorn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121031/42e9c258/attachment.htm>


More information about the asterisk-dev mailing list