[asterisk-dev] [Code Review]: Changes from Mantis ID 13495 in trunk.

[KNK]

> On Oct. 17, 2012, 1:24 p.m., rmudgett wrote:
> > Close this reivew and create a new review.  The review history is causing opening the review to be slow.

Will close this one and open a new review. Only the comments here.


> On Oct. 17, 2012, 1:24 p.m., rmudgett wrote:
> > /team/rmudgett/ss7_27_knk/channels/sig_ss7.c, line 2612
> > <https://reviewboard.asterisk.org/r/1676/diff/16/?file=31760#file31760line2612>
> >
> >     This line goes in the else clause.

Fixed.


> On Oct. 17, 2012, 1:24 p.m., rmudgett wrote:
> > /team/rmudgett/ss7_27_knk/channels/sig_ss7.c, lines 2848-2849
> > <https://reviewboard.asterisk.org/r/1676/diff/16/?file=31760#file31760line2848>
> >
> >     I don't think this change is necessary.

I must have misunderstood your comment then:
"Need to also check if the soft-hangup flags were set here to abort the outgoing call.  sig_ss7_cb_hangup() sets the AST_SOFTHANGUP_DEV flag on a collision."
Could you please elaborate on that.


> On Oct. 17, 2012, 1:24 p.m., rmudgett wrote:
> > /team/rmudgett/ss7_27_knk/channels/sig_ss7.c, lines 3269-3276
> > <https://reviewboard.asterisk.org/r/1676/diff/16/?file=31760#file31760line3269>
> >
> >     This failure to allocate an ast_channel structure needs to also clean up the p->ss7call allocated by the sig_ss7_available() function.  We are no longer going to send an IAM on this channel.

Done.


- KNK


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1676/#review7292
-----------------------------------------------------------


On Oct. 5, 2012, 9:51 a.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1676/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2012, 9:51 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> chan_dahdi / sig_ss7 part of changes
> 
> 
> This addresses bug SS7-27.
>     https://issues.asterisk.org/jira/browse/SS7-27
> 
> 
> Diffs
> -----
> 
>   /team/rmudgett/ss7_27_knk/channels/sig_ss7.c 374523 
> 
> Diff: https://reviewboard.asterisk.org/r/1676/diff
> 
> 
> Testing
> -------
> 
> compiles, link setup, cli commands, bassic calls, connected line and redirection.
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121030/706092bf/attachment-0001.htm>