[asterisk-dev] [Code Review] Changes from Mantis ID 13495 in trunk.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1676/#review7292
-----------------------------------------------------------


Close this reivew and create a new review.  The review history is causing opening the review to be slow.


/team/rmudgett/ss7_27_knk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/1676/#comment14081>

    This line goes in the else clause.



/team/rmudgett/ss7_27_knk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/1676/#comment14082>

    I don't think this change is necessary.



/team/rmudgett/ss7_27_knk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/1676/#comment14083>

    This failure to allocate an ast_channel structure needs to also clean up the p->ss7call allocated by the sig_ss7_available() function.  We are no longer going to send an IAM on this channel.


- rmudgett


On Oct. 5, 2012, 9:51 a.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1676/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2012, 9:51 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> chan_dahdi / sig_ss7 part of changes
> 
> 
> This addresses bug SS7-27.
>     https://issues.asterisk.org/jira/browse/SS7-27
> 
> 
> Diffs
> -----
> 
>   /team/rmudgett/ss7_27_knk/channels/sig_ss7.c 374523 
> 
> Diff: https://reviewboard.asterisk.org/r/1676/diff
> 
> 
> Testing
> -------
> 
> compiles, link setup, cli commands, bassic calls, connected line and redirection.
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121017/e636bc1d/attachment-0001.htm>