[asterisk-dev] [Code Review] chan_dahdi: Disable cancallforward and callreturn

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2158/#review7284
-----------------------------------------------------------



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/2158/#comment14059>

    Adding this feature should be in a separate patch.  Also it should not have dahdi in the name.
    
    Possible names:
    analog_feature_codes
    analog_features



/trunk/configs/chan_dahdi.conf.sample
<https://reviewboard.asterisk.org/r/2158/#comment14061>

    Delete this sentence:
    chan_dahdi carries within it legacy code from the time the feature codes were hard-wired into the code of Asterisk.
    
    These features are not entirely replaced by features.conf.
    
    I expect these features are defined somewhere by some telco (Bellcore??) specification for analog lines.  (Except for the *0 code which is for a very specialized use case in Asterisk.)
    



/trunk/configs/chan_dahdi.conf.sample
<https://reviewboard.asterisk.org/r/2158/#comment14063>

    ...only work for analog channels.
    
    You cannot specify a FXO signaling type since the simple switch can be started for other signaling types for other reasons.  The functionality *normally* has meaning to FXO type signaling channels.



/trunk/configs/chan_dahdi.conf.sample
<https://reviewboard.asterisk.org/r/2158/#comment14062>

    Overriding the call forwarding and DND feature codes by the dialplan can make these features survive a restart.


- rmudgett


On Oct. 16, 2012, 9:30 a.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2158/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2012, 9:30 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> * Document the hard-wired chan_dahdi feature codes.
> * Disable cancallforward and callreturn by default.
> 
> I recently ran into an issue with a customer: a FreePBX system where all the feature codes were disabled in the FreePBX system. Still a certain extension had call forwarding in it. The sysadmin could not figure out why this is happening.
> 
> There is no good reason to keep having the hard-wired DAHDI feature codes enabled by default. They should be explicitly enabled. And not endorced by default in the sample configuration file. No reason to hint that "cancallforward" is needed for the standard call forwarding to work.
> 
> I would prefer to also add configuration variable to permit the use of dahdi_dnd and probably also hide_callerid.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_dahdi.c 375044 
>   /trunk/channels/sig_analog.h 375044 
>   /trunk/channels/sig_analog.c 375044 
>   /trunk/configs/chan_dahdi.conf.sample 375044 
> 
> Diff: https://reviewboard.asterisk.org/r/2158/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121016/c6ee11b5/attachment-0001.htm>