[asterisk-dev] [Code Review] chan_dahdi: Disable cancallforward and callreturn

[Tzafrir Cohen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2158/
-----------------------------------------------------------

(Updated Oct. 16, 2012, 9:30 a.m.)


Review request for Asterisk Developers.


Changes
-------

chan_dahdi: dahdi_handset_features
    
Take this one step further: Add dahdi_handset_features to chan_dahdi.conf to enable all the hardwired features (disabled by default).

Is that a good idea?


Summary
-------

* Document the hard-wired chan_dahdi feature codes.
* Disable cancallforward and callreturn by default.

I recently ran into an issue with a customer: a FreePBX system where all the feature codes were disabled in the FreePBX system. Still a certain extension had call forwarding in it. The sysadmin could not figure out why this is happening.

There is no good reason to keep having the hard-wired DAHDI feature codes enabled by default. They should be explicitly enabled. And not endorced by default in the sample configuration file. No reason to hint that "cancallforward" is needed for the standard call forwarding to work.

I would prefer to also add configuration variable to permit the use of dahdi_dnd and probably also hide_callerid.


Diffs (updated)
-----

  /trunk/channels/chan_dahdi.c 375044 
  /trunk/channels/sig_analog.h 375044 
  /trunk/channels/sig_analog.c 375044 
  /trunk/configs/chan_dahdi.conf.sample 375044 

Diff: https://reviewboard.asterisk.org/r/2158/diff


Testing
-------


Thanks,

Tzafrir

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121016/c39820fd/attachment.htm>