[asterisk-dev] [Code Review]: chan_dahdi: Disable cancallforward and callreturn

[Tzafrir Cohen]

> On Oct. 12, 2012, 6:12 p.m., rmudgett wrote:
> > /trunk/configs/chan_dahdi.conf.sample, lines 721-722
> > <https://reviewboard.asterisk.org/r/2158/diff/1/?file=31841#file31841line721>
> >
> >     ...work for FXS ports (FXO signaling type channels).

I know that. But I see no reason to further confuse the readers.


> On Oct. 12, 2012, 6:12 p.m., rmudgett wrote:
> > /trunk/channels/chan_dahdi.c, line 10146
> > <https://reviewboard.asterisk.org/r/2158/diff/1/?file=31840#file31840line10146>
> >
> >     *60 puts the last incoming call's caller-id number into the AstDB as a blacklisted number.
> >

Right. Though the code to handle them is duplicated between chan_dahdi.c and sig_analog.c, which is not the best practice.


> On Oct. 12, 2012, 6:12 p.m., rmudgett wrote:
> > /trunk/configs/chan_dahdi.conf.sample, lines 729-730
> > <https://reviewboard.asterisk.org/r/2158/diff/1/?file=31841#file31841line729>
> >
> >     Don't document that it also disables forward.  I think this is a bug.  I think setting getforward=0 was a cut and paste error when the do not disturb feature was added.

Fine. Also note that restarting asterisk (or evn 'dahdi restart' also disables most such features, which is rather counter-intuitive.


> On Oct. 12, 2012, 6:12 p.m., rmudgett wrote:
> > /trunk/configs/chan_dahdi.conf.sample, line 734
> > <https://reviewboard.asterisk.org/r/2158/diff/1/?file=31841#file31841line734>
> >
> >     Performs a flash hook on the held call's bridged peer.  (Only if that peer is an analog DAHDI channel.)  This is a very specialized feature code so you can perform flash hooks on an analog trunk line.

The description above is too long to fit in my stanza which makes me feel a bit uncomfortable about this. How do you do a hook flash on an analog trunk from a SIP phone?


- Tzafrir


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2158/#review7273
-----------------------------------------------------------


On Oct. 11, 2012, 3:08 p.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2158/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 3:08 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> * Document the hard-wired chan_dahdi feature codes.
> * Was there any *60?
> * Disable cancallforward and callreturn by default.
> 
> I recently ran into an issue with a customer: a FreePBX system where all the feature codes were disabled in the FreePBX system. Still a certain extension had call forwarding in it. The sysadmin could not figure out why this is happening.
> 
> There is no good reason to keep having the hard-wired DAHDI feature codes enabled by default. They should be explicitly enabled. And not endorced by default in the sample configuration file. No reason to hint that "cancallforward" is needed for the standard call forwarding to work.
> 
> I would prefer to also add configuration variable to permit the use of dahdi_dnd and probably also hide_callerid.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_dahdi.c 374852 
>   /trunk/configs/chan_dahdi.conf.sample 374852 
> 
> Diff: https://reviewboard.asterisk.org/r/2158/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121016/0d16a864/attachment.htm>