[asterisk-dev] [Code Review] chan_dahdi: Disable cancallforward and callreturn

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2158/#review7273
-----------------------------------------------------------


You should be looking in sig_analog() to determine what the hard coded features mean.  A lot of code in chan_dahdi.c for analog is effectively dead.  It is only accessed if the struct dahdi_pvt radio or oprmode members are nonzero.


/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/2158/#comment14043>

    *60 puts the last incoming call's caller-id number into the AstDB as a blacklisted number.
    



/trunk/configs/chan_dahdi.conf.sample
<https://reviewboard.asterisk.org/r/2158/#comment14045>

    ...work for FXS ports (FXO signaling type channels).



/trunk/configs/chan_dahdi.conf.sample
<https://reviewboard.asterisk.org/r/2158/#comment14041>

    Disable call waiting for the call being placed.



/trunk/configs/chan_dahdi.conf.sample
<https://reviewboard.asterisk.org/r/2158/#comment14042>

    Says the number that last called.



/trunk/configs/chan_dahdi.conf.sample
<https://reviewboard.asterisk.org/r/2158/#comment14040>

    Don't document that it also disables forward.  I think this is a bug.  I think setting getforward=0 was a cut and paste error when the do not disturb feature was added.



/trunk/configs/chan_dahdi.conf.sample
<https://reviewboard.asterisk.org/r/2158/#comment14044>

    Performs a flash hook on the held call's bridged peer.  (Only if that peer is an analog DAHDI channel.)  This is a very specialized feature code so you can perform flash hooks on an analog trunk line.


- rmudgett


On Oct. 11, 2012, 3:08 p.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2158/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 3:08 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> * Document the hard-wired chan_dahdi feature codes.
> * Was there any *60?
> * Disable cancallforward and callreturn by default.
> 
> I recently ran into an issue with a customer: a FreePBX system where all the feature codes were disabled in the FreePBX system. Still a certain extension had call forwarding in it. The sysadmin could not figure out why this is happening.
> 
> There is no good reason to keep having the hard-wired DAHDI feature codes enabled by default. They should be explicitly enabled. And not endorced by default in the sample configuration file. No reason to hint that "cancallforward" is needed for the standard call forwarding to work.
> 
> I would prefer to also add configuration variable to permit the use of dahdi_dnd and probably also hide_callerid.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_dahdi.c 374852 
>   /trunk/configs/chan_dahdi.conf.sample 374852 
> 
> Diff: https://reviewboard.asterisk.org/r/2158/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121012/b3bd2d41/attachment.htm>