[asterisk-dev] [Code Review] Make dialplan variable evaluation case-sensitive

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2160/
-----------------------------------------------------------

(Updated Oct. 12, 2012, 9:48 a.m.)


Review request for Asterisk Developers.


Changes
-------

Incorporated Tilghman's suggestion.

I attempted to modify the wiki page based on Richard's feedback, but the wiki is encountering errors when I save my changes.


Summary
-------

For more information on this, see this companion wiki page: https://wiki.asterisk.org/wiki/display/AST/Case+Sensitivity

In this review, please comment both on the code change and the wiki page. I don't suspect there will be much to comment on in the code...


This addresses bug ASTERISK-20163.
    https://issues.asterisk.org/jira/browse/ASTERISK-20163


Diffs (updated)
-----

  /trunk/apps/app_osplookup.c 374848 
  /trunk/channels/chan_mgcp.c 374848 
  /trunk/channels/chan_sip.c 374849 
  /trunk/channels/chan_skinny.c 374848 
  /trunk/funcs/func_strings.c 374848 
  /trunk/main/pbx.c 374848 

Diff: https://reviewboard.asterisk.org/r/2160/diff


Testing
-------

I ran some calls where I set variables and ensured that they only evaluated to non-empty strings when the same case was used as when originally setting the variable.


Thanks,

Mark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121012/f2e0c9ec/attachment.htm>