[asterisk-dev] [Code Review] Make dialplan variable evaluation case-sensitive

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2160/#review7269
-----------------------------------------------------------


You're missing quite a few places in the code where we iterate over the list returned by ast_channel_varshead and use a case-insensitive comparison.  Look in funcs/func_strings.c, apps/app_osplookup.c, and channels/*.c, just for starters.

- Tilghman


On Oct. 11, 2012, 4:59 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2160/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 4:59 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> For more information on this, see this companion wiki page: https://wiki.asterisk.org/wiki/display/AST/Case+Sensitivity
> 
> In this review, please comment both on the code change and the wiki page. I don't suspect there will be much to comment on in the code...
> 
> 
> This addresses bug ASTERISK-20163.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20163
> 
> 
> Diffs
> -----
> 
>   /trunk/main/pbx.c 374848 
> 
> Diff: https://reviewboard.asterisk.org/r/2160/diff
> 
> 
> Testing
> -------
> 
> I ran some calls where I set variables and ensured that they only evaluated to non-empty strings when the same case was used as when originally setting the variable.
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121011/27b8863c/attachment.htm>