[asterisk-dev] [Code Review] Get mixmonitor_audiohook_inherit test working again

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2139/#review7244
-----------------------------------------------------------



/asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/run-test
<https://reviewboard.asterisk.org/r/2139/#comment13975>

    I don't think this method exists :-)
    
    To catch these kinds of errors, you may want to consider running pylint on your code.  Even if you decide not to fix all of the style findings (which are still good to fix), it will catch errors like this and flag them for you.



/asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/run-test
<https://reviewboard.asterisk.org/r/2139/#comment13976>

    Add an errback handler to this Originate.  You expect the call to get Answered, and if for some reason it doesn't, you would want to fail the test.



/asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/test-config.yaml
<https://reviewboard.asterisk.org/r/2139/#comment13973>

    This description is no longer accurate, as the console channel driver is no longer used.



/asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/test-config.yaml
<https://reviewboard.asterisk.org/r/2139/#comment13974>

    Since you're using TestEvents, this min version needs to bumped to the minimum version of Asterisk (1.8) that would contain these test events.


- Matt


On Oct. 1, 2012, 6:01 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2139/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2012, 6:01 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Summary
> -------
> 
> This is part of an effort to get tests working that are currently being skipped due to failures. I went ahead and changed this test to use the TestCase class since the old way of doing things was driving me nuts with various problems.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/configs/ast1/extensions.conf 3480 
>   /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/configs/ast1/features.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/configs/ast1/manager.conf 3480 
>   /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/run-test 3480 
>   /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/test-config.yaml 3480 
> 
> Diff: https://reviewboard.asterisk.org/r/2139/diff
> 
> 
> Testing
> -------
> 
> To test the test I ran the test with normal conditions, with an improper filename specified for the mixmonitor command, and also with turning off audiohook_inherit. All deviations caused failure as expected.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121006/0e7d3ea1/attachment.htm>