[asterisk-dev] [Code Review] Get mixmonitor_audiohook_inherit test working again

jrose reviewboard at asterisk.org
Mon Oct 1 18:01:55 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2139/
-----------------------------------------------------------

(Updated Oct. 1, 2012, 6:01 p.m.)


Review request for Asterisk Developers and Matt Jordan.


Changes
-------

Add test events.  This now relies on a new test event sent from asterisk proper that gets sent when a mixmonitor is ending.

The file size check is left in for now, but could be removed.  Unfortunately the new way of doing things requires some time padding making the file recorded somewhat larger.


Summary
-------

This is part of an effort to get tests working that are currently being skipped due to failures. I went ahead and changed this test to use the TestCase class since the old way of doing things was driving me nuts with various problems.


Diffs (updated)
-----

  /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/configs/ast1/extensions.conf 3480 
  /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/configs/ast1/features.conf PRE-CREATION 
  /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/configs/ast1/manager.conf 3480 
  /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/run-test 3480 
  /asterisk/trunk/tests/apps/mixmonitor_audiohook_inherit/test-config.yaml 3480 

Diff: https://reviewboard.asterisk.org/r/2139/diff


Testing
-------

To test the test I ran the test with normal conditions, with an improper filename specified for the mixmonitor command, and also with turning off audiohook_inherit. All deviations caused failure as expected.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121001/2d40f5d9/attachment.htm>


More information about the asterisk-dev mailing list