[asterisk-dev] [Code Review] More bridge tests; Add CDR and CEL checking to bridge tests

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2067/#review7419
-----------------------------------------------------------


I think that's a reasonable chunk of CEL events to test.

I'm a bit concerned that the order of CEL events will change and this will fail the test (for some reason, it feels like that was an issue the last time I wrote a test that checked CEL, but I could be mistaken).  I imagine we'll catch that problem relatively quickly once this goes in.

- Matt


On Aug. 8, 2012, 3:18 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2067/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 3:18 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This review serves two purposes.
> 
> First, it adds some more two-party bridge tests that simply test the reception and acknowledgement of DTMF features. The tests added are a automon, automixmon, and blind transfer tests.
> 
> Second, CDR and CEL checking have been added for the existing bridge tests as well as the new tests. This is probably the part that needs the most scrutiny since I picked and chose portions of the CDR and CEL events that were important to be checking. If there are additional fields that should be checked, let me know. The CDR and CEL fields checked from test to test are mostly the same, so there's no need to go over it with a fine-toothed comb.
> 
> Some notes:
> 
> I modified the BridgeTestCase.py file to not move on to subsequent calls until hangup events have been received for *all* channels involved in the call. This helped to ensure that CEL events were always ordered in the same way.
> 
> If you skim through the CEL configs, you'll find a couple of files where there are some XXX comments. First, the automon test's APP_END events do not have a dnid set. All the other tests have this set. Second, when the disconnect feature is used to end a call, the eventextra field of the HANGUP event does not have a hangup source. Both of these strike me as odd, but I don't want to go on record as calling them bugs yet since the behavior may be intentional.
> 
> 
> Diffs
> -----
> 
>   /asterisk/team/mmichelson/bridge-tests/lib/python/asterisk/BridgeTestCase.py 3409 
>   /asterisk/team/mmichelson/bridge-tests/tests/bridge/atxfer/test-config.yaml 3409 
>   /asterisk/team/mmichelson/bridge-tests/tests/bridge/automixmon/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mmichelson/bridge-tests/tests/bridge/automixmon/test-config.yaml PRE-CREATION 
>   /asterisk/team/mmichelson/bridge-tests/tests/bridge/automon/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mmichelson/bridge-tests/tests/bridge/automon/test-config.yaml PRE-CREATION 
>   /asterisk/team/mmichelson/bridge-tests/tests/bridge/blindxfer/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mmichelson/bridge-tests/tests/bridge/blindxfer/test-config.yaml PRE-CREATION 
>   /asterisk/team/mmichelson/bridge-tests/tests/bridge/disconnect/test-config.yaml 3409 
>   /asterisk/team/mmichelson/bridge-tests/tests/bridge/simple_bridge/test-config.yaml 3409 
> 
> Diff: https://reviewboard.asterisk.org/r/2067/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121120/361a9303/attachment-0001.htm>