<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2067/">https://reviewboard.asterisk.org/r/2067/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think that's a reasonable chunk of CEL events to test.
I'm a bit concerned that the order of CEL events will change and this will fail the test (for some reason, it feels like that was an issue the last time I wrote a test that checked CEL, but I could be mistaken). I imagine we'll catch that problem relatively quickly once this goes in.</pre>
<br />
<p>- Matt</p>
<br />
<p>On August 8th, 2012, 3:18 p.m., Mark Michelson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2012, 3:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review serves two purposes.
First, it adds some more two-party bridge tests that simply test the reception and acknowledgement of DTMF features. The tests added are a automon, automixmon, and blind transfer tests.
Second, CDR and CEL checking have been added for the existing bridge tests as well as the new tests. This is probably the part that needs the most scrutiny since I picked and chose portions of the CDR and CEL events that were important to be checking. If there are additional fields that should be checked, let me know. The CDR and CEL fields checked from test to test are mostly the same, so there's no need to go over it with a fine-toothed comb.
Some notes:
I modified the BridgeTestCase.py file to not move on to subsequent calls until hangup events have been received for *all* channels involved in the call. This helped to ensure that CEL events were always ordered in the same way.
If you skim through the CEL configs, you'll find a couple of files where there are some XXX comments. First, the automon test's APP_END events do not have a dnid set. All the other tests have this set. Second, when the disconnect feature is used to end a call, the eventextra field of the HANGUP event does not have a hangup source. Both of these strike me as odd, but I don't want to go on record as calling them bugs yet since the behavior may be intentional.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/team/mmichelson/bridge-tests/lib/python/asterisk/BridgeTestCase.py <span style="color: grey">(3409)</span></li>
<li>/asterisk/team/mmichelson/bridge-tests/tests/bridge/atxfer/test-config.yaml <span style="color: grey">(3409)</span></li>
<li>/asterisk/team/mmichelson/bridge-tests/tests/bridge/automixmon/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/bridge-tests/tests/bridge/automixmon/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/bridge-tests/tests/bridge/automon/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/bridge-tests/tests/bridge/automon/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/bridge-tests/tests/bridge/blindxfer/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/bridge-tests/tests/bridge/blindxfer/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/bridge-tests/tests/bridge/disconnect/test-config.yaml <span style="color: grey">(3409)</span></li>
<li>/asterisk/team/mmichelson/bridge-tests/tests/bridge/simple_bridge/test-config.yaml <span style="color: grey">(3409)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2067/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>