[asterisk-dev] Wideband/variable bandwidth modification of app_jack

[Mathis Schmieder]

Thanks for the comments!

Regarding 1) - will do that, I'll just have to remember to set up vim that
way..
2) Right, as discussed via twitter, will work on that towards the end of
the week and will resubmit a patch somewhen this weekend I guess.

One thing I would appreciate would be if someone could point me in the
right direction towards what Jamuel wrote - opening a review board with my
enhancements. Not exactly sure what he meant, this is my first time working
with Jira :)

Mathis


--
mobile +49.151.23010807
jabber mathis at jabber.berlin.ccc.de
facebook https://www.facebook.com/mathis.schmieder

Respect the environment and do not print out this mail.


On Tue, Nov 20, 2012 at 1:49 PM, Russell Bryant
<russell at russellbryant.net>wrote:

> On Sun, Nov 18, 2012 at 1:34 PM, Mathis Schmieder <
> mathis.schmieder at gmail.com> wrote:
>
>> Thanks for the advice, did just that:
>> https://issues.asterisk.org/jira/browse/ASTERISK-20696
>>
>>
> Some patch comments:
>
> 1) It looks like you have some mixed usage of tabs and spaces.  Use tabs.
>
> 2) As we were discussing via twitter, I think it would make sense to have
> this happen automatically instead of as an option.  You can check the codec
> in use by the channel and choose the sample rate based on that.
>
> Something like ...
>
>     ast_format_rate(ast_channel_readformat(chan))
>
> --
> Russell Bryant
>
>
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/asterisk-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121120/914922f5/attachment.htm>