Thanks for the comments!<div><br></div><div>Regarding 1) - will do that, I'll just have to remember to set up vim that way..</div><div>2) Right, as discussed via twitter, will work on that towards the end of the week and will resubmit a patch somewhen this weekend I guess. </div>
<div><br></div><div>One thing I would appreciate would be if someone could point me in the right direction towards what Jamuel wrote - opening a review board with my enhancements. Not exactly sure what he meant, this is my first time working with Jira :)</div>
<div><br></div><div>Mathis</div><div class="gmail_extra"><br clear="all"><div><br></div>--<br>mobile +49.151.23010807<br>jabber <a href="mailto:mathis@jabber.berlin.ccc.de" target="_blank">mathis@jabber.berlin.ccc.de</a><br>
facebook <a href="https://www.facebook.com/mathis.schmieder" target="_blank">https://www.facebook.com/mathis.schmieder</a><br><br>Respect the environment and do not print out this mail.<br>
<br><br><div class="gmail_quote">On Tue, Nov 20, 2012 at 1:49 PM, Russell Bryant <span dir="ltr"><<a href="mailto:russell@russellbryant.net" target="_blank">russell@russellbryant.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Sun, Nov 18, 2012 at 1:34 PM, Mathis Schmieder <span dir="ltr"><<a href="mailto:mathis.schmieder@gmail.com" target="_blank">mathis.schmieder@gmail.com</a>></span> wrote:<br></div><div class="gmail_extra">
<div class="gmail_quote"><div class="im">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks for the advice, did just that:<div><a href="https://issues.asterisk.org/jira/browse/ASTERISK-20696" target="_blank">https://issues.asterisk.org/jira/browse/ASTERISK-20696</a><br>
</div><div class="gmail_extra"><br></div></blockquote><div><br></div></div><div>Some patch comments:</div><div><br></div><div>1) It looks like you have some mixed usage of tabs and spaces. Use tabs.</div><div><br></div>
<div>2) As we were discussing via twitter, I think it would make sense to have this happen automatically instead of as an option. You can check the codec in use by the channel and choose the sample rate based on that.</div>
<div><br></div><div>Something like ...</div><div><br></div><div> ast_format_rate(ast_channel_readformat(chan))</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>-- </div><div>Russell Bryant</div><div>
<br></div></font></span></div></div>
<br>--<br>
_____________________________________________________________________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" target="_blank">http://www.api-digital.com</a> --<br>
<br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br></blockquote></div><br></div>