[asterisk-dev] [Code Review]: Add unique message IDs to IMAP voicemail

[Mark Michelson]

> On May 30, 2012, 3:57 p.m., Matt Jordan wrote:
> > /team/mmichelson/trunk-digiumphones/apps/app_voicemail.c, lines 2023-2026
> > <https://reviewboard.asterisk.org/r/1945/diff/1/?file=28244#file28244line2023>
> >
> >     Both mail_copy and imap_store_file can theoretically fail - this would mean we would delete the original message and not replace it with the new one.  Only perform vm_imap_delete if imap_store_file and save_to_folder succeed.
> >

I have opted to call vm_imap_delete() if imap_store_file() succeeds. Even if save_to_folder() should fail, it's good to get rid of the old message that has no message ID. Presumably, the user can later move the message to the appropriate folder.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1945/#review6351
-----------------------------------------------------------


On May 23, 2012, 3:46 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1945/
> -----------------------------------------------------------
> 
> (Updated May 23, 2012, 3:46 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This review has two main parts to it.
> 
> 1) IMAP voicemail storage now supports unique message IDs like the other storage backends.
> 2) Old IMAP voicemails that do not have a unique message ID can be updated to have one now. This involves deleting the old message, creating a new one, and then storing that message in the appropriate folder. Comments in the code explain what is going on.
> 
> 
> Diffs
> -----
> 
>   /team/mmichelson/trunk-digiumphones/apps/app_voicemail.c 367360 
> 
> Diff: https://reviewboard.asterisk.org/r/1945/diff
> 
> 
> Testing
> -------
> 
> Admittedly, this has only undergone a compilation test.
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120531/bd216c0e/attachment.htm>