[asterisk-dev] [Code Review] Add unique message IDs to IMAP voicemail

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1945/#review6354
-----------------------------------------------------------



/team/mmichelson/trunk-digiumphones/apps/app_voicemail.c
<https://reviewboard.asterisk.org/r/1945/#comment11862>

    Blob.



/team/mmichelson/trunk-digiumphones/apps/app_voicemail.c
<https://reviewboard.asterisk.org/r/1945/#comment11863>

    The channel opaquification changes here seem out of place.  Was this just forgotten and not actually compiling before?



/team/mmichelson/trunk-digiumphones/apps/app_voicemail.c
<https://reviewboard.asterisk.org/r/1945/#comment11865>

    Blob.


- opticron


On May 23, 2012, 3:46 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1945/
> -----------------------------------------------------------
> 
> (Updated May 23, 2012, 3:46 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This review has two main parts to it.
> 
> 1) IMAP voicemail storage now supports unique message IDs like the other storage backends.
> 2) Old IMAP voicemails that do not have a unique message ID can be updated to have one now. This involves deleting the old message, creating a new one, and then storing that message in the appropriate folder. Comments in the code explain what is going on.
> 
> 
> Diffs
> -----
> 
>   /team/mmichelson/trunk-digiumphones/apps/app_voicemail.c 367360 
> 
> Diff: https://reviewboard.asterisk.org/r/1945/diff
> 
> 
> Testing
> -------
> 
> Admittedly, this has only undergone a compilation test.
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120531/efa77d1e/attachment-0001.htm>