[asterisk-dev] [Code Review]: Enable support for early media in AMI originate action

[Mark Michelson]

> On May 17, 2012, 8:08 a.m., Matt Jordan wrote:
> > /trunk/main/pbx.c, lines 8707-8709
> > <https://reviewboard.asterisk.org/r/1472/diff/2/?file=21514#file21514line8707>
> >
> >     Remove option_debug; change ast_log to ast_debug(1, "...");

nit: Should actually be ast_debug(2, "..."); since the original requirement was to have option_debug > 1.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1472/#review6230
-----------------------------------------------------------


On Oct. 31, 2011, 7:24 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1472/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2011, 7:24 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds support for early media in AMI action originate. Previously, we bridged at answer. In some cases when originating, you want to hear early media too, as important information might hide in there.
> 
> I saw the red dot first. I will kill it myself.
> 
> 
> This addresses bug ASTERISK-18644.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18644
> 
> 
> Diffs
> -----
> 
>   /trunk/pbx/pbx_spool.c 342755 
>   /trunk/res/res_clioriginate.c 342755 
>   /trunk/main/pbx.c 342755 
>   /trunk/CHANGES 342755 
>   /trunk/apps/app_originate.c 342755 
>   /trunk/include/asterisk/channel.h 342755 
>   /trunk/include/asterisk/pbx.h 342755 
>   /trunk/main/channel.c 342755 
>   /trunk/main/manager.c 342755 
> 
> Diff: https://reviewboard.asterisk.org/r/1472/diff
> 
> 
> Testing
> -------
> 
> Two weeks ago, we put the 1.4 version of this patch in production. The ladies placing calls are very happy now that they hear that the number they have dialed is not available.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120517/1dba5dc4/attachment.htm>