[asterisk-dev] [Code Review] Enable support for early media in AMI originate action

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1472/#review6230
-----------------------------------------------------------



/trunk/CHANGES
<https://reviewboard.asterisk.org/r/1472/#comment11541>

    This should probably use CamelCase for the option name (so EarlyMedia)



/trunk/include/asterisk/pbx.h
<https://reviewboard.asterisk.org/r/1472/#comment11542>

    All instances of the variable name 'earlymedia' should probably 'early_media'



/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/1472/#comment11543>

    "bridgeearly" should be "bridge_early"



/trunk/main/pbx.c
<https://reviewboard.asterisk.org/r/1472/#comment11544>

    "haveearlymedia" should be "have_early_media"



/trunk/main/pbx.c
<https://reviewboard.asterisk.org/r/1472/#comment11545>

    If the condition is true, the frame will be leaked.  ast_frfree needs to be called prior to breaking out of the while loop.



/trunk/main/pbx.c
<https://reviewboard.asterisk.org/r/1472/#comment11546>

    Remove option_debug; change ast_log to ast_debug(1, "...");


- Matt


On Oct. 31, 2011, 7:24 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1472/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2011, 7:24 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds support for early media in AMI action originate. Previously, we bridged at answer. In some cases when originating, you want to hear early media too, as important information might hide in there.
> 
> I saw the red dot first. I will kill it myself.
> 
> 
> This addresses bug ASTERISK-18644.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18644
> 
> 
> Diffs
> -----
> 
>   /trunk/pbx/pbx_spool.c 342755 
>   /trunk/res/res_clioriginate.c 342755 
>   /trunk/main/pbx.c 342755 
>   /trunk/CHANGES 342755 
>   /trunk/apps/app_originate.c 342755 
>   /trunk/include/asterisk/channel.h 342755 
>   /trunk/include/asterisk/pbx.h 342755 
>   /trunk/main/channel.c 342755 
>   /trunk/main/manager.c 342755 
> 
> Diff: https://reviewboard.asterisk.org/r/1472/diff
> 
> 
> Testing
> -------
> 
> Two weeks ago, we put the 1.4 version of this patch in production. The ladies placing calls are very happy now that they hear that the number they have dialed is not available.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120517/24d71c7d/attachment.htm>