[asterisk-dev] asterisk-dev Digest, Vol 94, Issue 37

bell_n_tell786 at yahoo.com bell_n_tell786 at yahoo.com
Wed May 9 10:23:58 CDT 2012


Ass hole 
Sent from my BlackBerry® smartphone from Warid.

-----Original Message-----
From: asterisk-dev-request at lists.digium.com
Sender: asterisk-dev-bounces at lists.digium.com
Date: Wed, 09 May 2012 10:14:48 
To: <asterisk-dev at lists.digium.com>
Reply-To: asterisk-dev at lists.digium.com
Subject: asterisk-dev Digest, Vol 94, Issue 37

Send asterisk-dev mailing list submissions to
	asterisk-dev at lists.digium.com

To subscribe or unsubscribe via the World Wide Web, visit
	http://lists.digium.com/mailman/listinfo/asterisk-dev
or, via email, send a message with subject or body 'help' to
	asterisk-dev-request at lists.digium.com

You can reach the person managing the list at
	asterisk-dev-owner at lists.digium.com

When replying, please edit your Subject line so it is more specific
than "Re: Contents of asterisk-dev digest..."


Today's Topics:

   1. Re: Pinequeue - to hold or not to hold (Bryant Zimmerman)
   2. Re: Pinequeue - to hold or not to hold (Olle E. Johansson)
   3. Re: [Code Review]: Pinequeue: Play queue prompts in the
      background - making call available to agent faster (Tilghman Lesher)
   4. Re: asterisk-dev Digest, Vol 94, Issue 36
      (bell_n_tell786 at yahoo.com)


----------------------------------------------------------------------

Message: 1
Date: Wed, 9 May 2012 10:42:53 -0400
From: "Bryant Zimmerman" <BryantZ at zktech.com>
Subject: Re: [asterisk-dev] Pinequeue - to hold or not to hold
To: "Asterisk Developers Mailing List" <asterisk-dev at lists.digium.com>
Message-ID: <7c249e73$369d9376$19761eb9$@com>
Content-Type: text/plain; charset="us-ascii"

Olle

If it is stable what is the objection to letting it go through. The premise 
behind it appears to be sound and would enhance the responsiveness of the 
queue system. 

Thanks

Bryant Zimmerman (ZK Tech Inc.)
616-855-1030 Ext. 2003 

----------------------------------------
 From: "Olle E. Johansson" <oej at edvina.net>
Sent: Wednesday, May 09, 2012 10:26 AM
To: "Asterisk Developers Mailing List" <asterisk-dev at lists.digium.com>
Subject: [asterisk-dev] Pinequeue - to hold or not to hold

https://reviewboard.asterisk.org/r/1887/

Leif strongly wants to put this on hold, I think it is a great addition as 
it is and don't think his claim is valid.

I need some consensus on what to do. If the dev team wants to put this on 
hold, fine, then I won't spend any time on fixing the code according to the 
rest of the review feedback. If the dev team wants this feature, I will 
continue to work on it towards a merge into the source code.

I need a decision so I can either continue or close the review, I don't 
want to have another review that stays out there without feedback for ages, 
as I actually have pretty good feedback to work on.

Cheers,
/O
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120509/18326e5a/attachment-0001.htm>

------------------------------

Message: 2
Date: Wed, 9 May 2012 16:50:33 +0200
From: "Olle E. Johansson" <oej at edvina.net>
Subject: Re: [asterisk-dev] Pinequeue - to hold or not to hold
To: bryantz at zktech.com,	Asterisk Developers Mailing List
	<asterisk-dev at lists.digium.com>
Message-ID: <C4662074-B5B3-4A30-82E9-123B0A898293 at edvina.net>
Content-Type: text/plain; charset=iso-8859-1


9 maj 2012 kl. 16:42 skrev Bryant Zimmerman:

> Olle
> 
> If it is stable what is the objection to letting it go through. The premise behind it appears to be sound and would enhance the responsiveness of the queue system. 
Please read the review to follow the conversation between me and Leif.

Thanks for the feedback!

/O
> 
> Thanks
> 
> Bryant Zimmerman (ZK Tech Inc.)
> 616-855-1030 Ext. 2003
> 
> 
> From: "Olle E. Johansson" <oej at edvina.net>
> Sent: Wednesday, May 09, 2012 10:26 AM
> To: "Asterisk Developers Mailing List" <asterisk-dev at lists.digium.com>
> Subject: [asterisk-dev] Pinequeue - to hold or not to hold
> 
> https://reviewboard.asterisk.org/r/1887/
> 
> Leif strongly wants to put this on hold, I think it is a great addition as it is and don't think his claim is valid.
> 
> I need some consensus on what to do. If the dev team wants to put this on hold, fine, then I won't spend any time on fixing the code according to the rest of the review feedback. If the dev team wants this feature, I will continue to work on it towards a merge into the source code.
> 
> I need a decision so I can either continue or close the review, I don't want to have another review that stays out there without feedback for ages, as I actually have pretty good feedback to work on.
> 
> Cheers,
> /O
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
> 
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
> http://lists.digium.com/mailman/listinfo/asterisk-dev
> 
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
> 
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>   http://lists.digium.com/mailman/listinfo/asterisk-dev

---
* Olle E Johansson - oej at edvina.net
* Cell phone +46 70 593 68 51, Office +46 8 96 40 20, Sweden






------------------------------

Message: 3
Date: Wed, 09 May 2012 14:59:36 -0000
From: "Tilghman Lesher" <reviewboard at asterisk.org>
Subject: Re: [asterisk-dev] [Code Review]: Pinequeue: Play queue
	prompts in the background - making call available to agent faster
To: "Olle E Johansson" <oej at edvina.net>,	"Tilghman Lesher"
	<tilghman at meg.abyt.es>,	"Tilghman Lesher" <reviewboard at asterisk.org>,
	"Mark Michelson" <mmichelson at digium.com>,	"Asterisk Developers"
	<asterisk-dev at lists.digium.com>
Message-ID: <20120509145936.5016.39630 at hotblack.digium.com>
Content-Type: text/plain; charset="utf-8"



> On April 26, 2012, 5:48 p.m., Mark Michelson wrote:
> > /trunk/apps/app_queue.c, line 6444
> > <https://reviewboard.asterisk.org/r/1887/diff/2/?file=27573#file27573line6444>
> >
> >     When was autoservice started?
> 
> Olle E Johansson wrote:
>     The channel could already have something running from earlier. Or?

Autoservice is designed such that the API can be called in a nested way, and it will still behave correctly.  If your intent is to stop autoservice, this isn't guaranteed to do that.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1887/#review6077
-----------------------------------------------------------


On April 26, 2012, 9:42 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1887/
> -----------------------------------------------------------
> 
> (Updated April 26, 2012, 9:42 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Today, when a prompt is being played to a call waiting in the queue and an agent becomes available, the agent will not get the call until the prompt is finished. Both customer and agent is kept waiting.
> 
> With this rather big piece of code, we attach a generator to play prompts. The generator can, like all generators, be stopped at any time so that the agent (queue member) can get the call immediately.
> 
> The generator is now placed in app_queue, but could propably be moved somewhere else. It also changes functionality in main/say.c in order to be able to place those prompts in the same prompt queue for background processing. The same generator could be used to sevice conference bridges and maybe be added as a dialplan function at some point for background playlists.
> 
> 
> This addresses bug 19795.
>     https://issues.asterisk.org/jira/browse/19795
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_queue.c 364000 
>   /trunk/configs/queues.conf.sample 364000 
>   /trunk/include/asterisk/channel.h 364000 
>   /trunk/include/asterisk/file.h 364000 
>   /trunk/main/asterisk.dynamics 364000 
>   /trunk/main/file.c 364000 
>   /trunk/main/say.c 364000 
> 
> Diff: https://reviewboard.asterisk.org/r/1887/diff
> 
> 
> Testing
> -------
> 
> Quite a lot of testing in our environment during the rather long time we've been testing this. Customer is happy.
> 
> 
> There was some complaints from a bowl of petunias, which made me a bit surprised.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120509/e6277b25/attachment-0001.htm>

------------------------------

Message: 4
Date: Wed, 9 May 2012 15:02:34 +0000
From: bell_n_tell786 at yahoo.com
Subject: Re: [asterisk-dev] asterisk-dev Digest, Vol 94, Issue 36
To: asterisk-dev at lists.digium.com
Message-ID:
	<1937495640-1336575754-cardhu_decombobulator_blackberry.rim.net-1077670785- at b15.c8.bise7.blackberry>
	
Content-Type: text/plain; charset="Windows-1252"

Fuck u 
Sent from my BlackBerry? smartphone from Warid.

-----Original Message-----
From: asterisk-dev-request at lists.digium.com
Sender: asterisk-dev-bounces at lists.digium.com
Date: Wed, 09 May 2012 09:57:19 
To: <asterisk-dev at lists.digium.com>
Reply-To: asterisk-dev at lists.digium.com
Subject: asterisk-dev Digest, Vol 94, Issue 36

Send asterisk-dev mailing list submissions to
	asterisk-dev at lists.digium.com

To subscribe or unsubscribe via the World Wide Web, visit
	http://lists.digium.com/mailman/listinfo/asterisk-dev
or, via email, send a message with subject or body 'help' to
	asterisk-dev-request at lists.digium.com

You can reach the person managing the list at
	asterisk-dev-owner at lists.digium.com

When replying, please edit your Subject line so it is more specific
than "Re: Contents of asterisk-dev digest..."


Today's Topics:

   1. Re: [Code Review] ICE, STUN, and TURN Support (Joshua Colp)
   2. Opensips/Asterisk developer (Ronnie Bulanek)
   3. Pinequeue - to hold or not to hold (Olle E. Johansson)
   4. Re: [Code Review] ICE, STUN, and TURN Support (Olle E Johansson)
   5. [Code Review] pass BUILD_CFLGAS and BUILD_LDFLAGS to
      menuselect (asterisk part) (Tzafrir Cohen)
   6. [Code Review] pass BUILD_CFLGAS and BUILD_LDFLAGS to
      menuselect (menuselect part) (Tzafrir Cohen)


----------------------------------------------------------------------

Message: 1
Date: Wed, 09 May 2012 13:46:36 -0000
From: "Joshua Colp" <reviewboard at asterisk.org>
Subject: Re: [asterisk-dev] [Code Review] ICE, STUN, and TURN Support
To: "Paul Belanger" <pabelanger at digium.com>,	"Joshua Colp"
	<reviewboard at asterisk.org>,	"Mark Michelson" <mmichelson at digium.com>,
	"Joshua Colp" <jcolp at digium.com>, "Terry Wilson" <twilson at digium.com>,
	"Asterisk Developers" <asterisk-dev at lists.digium.com>
Message-ID: <20120509134636.32312.80878 at hotblack.digium.com>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1891/
-----------------------------------------------------------

(Updated May 9, 2012, 8:46 a.m.)


Review request for Asterisk Developers.


Changes
-------

Updated with incorporated review feedback changes.


Summary
-------

This patch adds support for the following:

ICE attribute parsing and generation in chan_sip
Usage of the ICE interface in chan_sip
ICE support within res_rtp_asterisk
STUN support within res_rtp_asterisk for getting the server reflexive address
TURN support within res_rtp_asterisk for relaying traffic when needed
Additional configuration options for the above

One area which could use some feedback is the pjproject integration. Should we try to use their build system as I have done to integrate things, or try to roll their stuff into ours further?

If you would like some background on ICE and the actual support here take a gander at the wiki page located at https://wiki.asterisk.org/wiki/display/~jcolp/ICE%2C+STUN%2C+and+TURN+Support - hopefully it proves useful to you.


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 361952 
  /trunk/configs/rtp.conf.sample 361952 
  /trunk/include/asterisk/rtp_engine.h 361952 
  /trunk/main/rtp_engine.c 361952 
  /trunk/res/Makefile 361952 
  /trunk/res/res_rtp_asterisk.c 361952 

Diff: https://reviewboard.asterisk.org/r/1891/diff


Testing
-------

Tested various scenarios using Bria and X-Lite behind multiple NATs, different NATs, different internet connections but locally reachable, etc. It works well.


Thanks,

Joshua

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120509/82c97173/attachment-0001.htm>

------------------------------

Message: 2
Date: Wed, 9 May 2012 09:23:12 -0500
From: "Ronnie Bulanek" <RONNIE.BULANEK at businessuites.com>
Subject: [asterisk-dev] Opensips/Asterisk developer
To: <asterisk-dev at lists.digium.com>
Message-ID:
	<D911B019C1617C4F9507D73A963DE7BD03F15099 at bsshdcads01.colo.businessuites.com>
	
Content-Type: text/plain; charset="us-ascii"

We are looking for a developer to help us with the continued development
of a centralized Asterisk system with an Opensips proxy. This will be a
minimum of 2 year project. The project is located in Houston, Texas and
we would prefer to developer to be on-site to work with our in-house
team on this project. This should be a high level developer who has
experience with large systems and true SIP architecture. Call or email
me if there is any interests.

 

Thanks

 

Ronnie Bulanek

VP of Technology

BusinesSuites

24624 Interstate 45, Ste 200

Houston, Texas 77386

Ofc: (281)378-8080

Fax: (866)283-2217

Ronnie.bulanek at businessuites.com

 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120509/587baf8e/attachment-0001.htm>

------------------------------

Message: 3
Date: Wed, 9 May 2012 16:28:30 +0200
From: "Olle E. Johansson" <oej at edvina.net>
Subject: [asterisk-dev] Pinequeue - to hold or not to hold
To: Asterisk Developers Mailing List <asterisk-dev at lists.digium.com>
Message-ID: <33E7EBF3-E492-4201-846C-8F989AA858BB at edvina.net>
Content-Type: text/plain; charset=us-ascii

https://reviewboard.asterisk.org/r/1887/

Leif strongly wants to put this on hold, I think it is a great addition as it is and don't think his claim is valid.

I need some consensus on what to do. If the dev team wants to put this on hold, fine, then I won't spend any time on fixing the code according to the rest of the review feedback. If the dev team wants this feature, I will continue to work on it towards a merge into the source code.

I need a decision so I can either continue or close the review, I don't want to have another review that stays out there without feedback for ages, as I actually have pretty good feedback to work on.

Cheers,
/O


------------------------------

Message: 4
Date: Wed, 09 May 2012 14:32:11 -0000
From: "Olle E Johansson" <reviewboard at asterisk.org>
Subject: Re: [asterisk-dev] [Code Review] ICE, STUN, and TURN Support
To: "Joshua Colp" <jcolp at digium.com>,	"Olle E Johansson"
	<reviewboard at asterisk.org>,	"Asterisk Developers"
	<asterisk-dev at lists.digium.com>
Message-ID: <20120509143211.3520.87011 at hotblack.digium.com>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1891/#review6183
-----------------------------------------------------------


I just want to say that I am very very happy about this functionality. That's all. Thanks!

- Olle E


On May 9, 2012, 8:46 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1891/
> -----------------------------------------------------------
> 
> (Updated May 9, 2012, 8:46 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds support for the following:
> 
> ICE attribute parsing and generation in chan_sip
> Usage of the ICE interface in chan_sip
> ICE support within res_rtp_asterisk
> STUN support within res_rtp_asterisk for getting the server reflexive address
> TURN support within res_rtp_asterisk for relaying traffic when needed
> Additional configuration options for the above
> 
> One area which could use some feedback is the pjproject integration. Should we try to use their build system as I have done to integrate things, or try to roll their stuff into ours further?
> 
> If you would like some background on ICE and the actual support here take a gander at the wiki page located at https://wiki.asterisk.org/wiki/display/~jcolp/ICE%2C+STUN%2C+and+TURN+Support - hopefully it proves useful to you.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 361952 
>   /trunk/configs/rtp.conf.sample 361952 
>   /trunk/include/asterisk/rtp_engine.h 361952 
>   /trunk/main/rtp_engine.c 361952 
>   /trunk/res/Makefile 361952 
>   /trunk/res/res_rtp_asterisk.c 361952 
> 
> Diff: https://reviewboard.asterisk.org/r/1891/diff
> 
> 
> Testing
> -------
> 
> Tested various scenarios using Bria and X-Lite behind multiple NATs, different NATs, different internet connections but locally reachable, etc. It works well.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120509/e27f0c5f/attachment-0001.htm>

------------------------------

Message: 5
Date: Wed, 09 May 2012 14:45:33 -0000
From: "Tzafrir Cohen" <reviewboard at asterisk.org>
Subject: [asterisk-dev] [Code Review] pass BUILD_CFLGAS and
	BUILD_LDFLAGS to menuselect (asterisk part)
To: "Asterisk Developers" <asterisk-dev at lists.digium.com>,	"Tzafrir
	Cohen" <reviewboard at asterisk.org>,	"Tzafrir Cohen"
	<tzafrir.cohen at xorcom.com>
Message-ID: <20120509144533.4591.72946 at hotblack.digium.com>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1907/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Allow menuselect to get its set of CFLAGS and LDFLAGS through the
environment of Make:

  make BUILD_CFLAGS="whatever" BUILD_LDFLAGS="whatever"

The corresponding menuselect bits (review 1908) prevents menuselect from stepping over those.

Originally intended to allow Debian to pass ts own build flags to menuselect as well.


Diffs
-----

  /trunk/Makefile 365893 

Diff: https://reviewboard.asterisk.org/r/1907/diff


Testing
-------

It builds.


Thanks,

Tzafrir

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120509/629e35cf/attachment-0001.htm>

------------------------------

Message: 6
Date: Wed, 09 May 2012 14:47:44 -0000
From: "Tzafrir Cohen" <reviewboard at asterisk.org>
Subject: [asterisk-dev] [Code Review] pass BUILD_CFLGAS and
	BUILD_LDFLAGS to menuselect (menuselect part)
To: "Asterisk Developers" <asterisk-dev at lists.digium.com>,	"Tzafrir
	Cohen" <reviewboard at asterisk.org>,	"Tzafrir Cohen"
	<tzafrir.cohen at xorcom.com>
Message-ID: <20120509144744.4837.26382 at hotblack.digium.com>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1908/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Review 1907 allows passing CFLAGS and LDFLAGS to menuselect. This review is intended to make sure menuselect won't step over them with empty values.
Furthermore, adding '-c' by default to CFLAGS is not a good idea.


Diffs
-----

  /trunk/Makefile 1032 

Diff: https://reviewboard.asterisk.org/r/1908/diff


Testing
-------


Thanks,

Tzafrir

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120509/b7ad15b9/attachment.htm>

------------------------------

_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

AstriCon 2010 - October 26-28 Washington, DC
Put in your talk proposal: http://www.bit.ly/speak-astricon2010

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

End of asterisk-dev Digest, Vol 94, Issue 36
********************************************

------------------------------

_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

AstriCon 2010 - October 26-28 Washington, DC
Put in your talk proposal: http://www.bit.ly/speak-astricon2010

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

End of asterisk-dev Digest, Vol 94, Issue 37
********************************************


More information about the asterisk-dev mailing list