[asterisk-dev] [Code Review]: Generate VMWI neon pulses from FXS module to light NEON lamp on older 'non intellegent phones'

[Mark Michelson]

> On April 30, 2012, 2:47 p.m., opticron wrote:
> > There are quite a few missing braces around ifs and elses, but I don't quite remember the coding guidelines for the DAHDI project, so those may not be an issue.

They use the Linux kernel coding guidelines. http://www.kernel.org/doc/Documentation/CodingStyle
See chapter 3 of the linked document. In most cases, single statement blocks get no braces. The exception is if, say, there is an if block with multiple statements with an else with only one statement. The else in that case would get braces since the if block also got braces.

That document annoys me because of the constant rationale of "K&R did it that way so it must be right" .


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1144/#review6121
-----------------------------------------------------------


On April 13, 2012, 5:37 a.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1144/
> -----------------------------------------------------------
> 
> (Updated April 13, 2012, 5:37 a.m.)
> 
> 
> Review request for Asterisk Developers and Shaun Ruffell.
> 
> 
> Summary
> -------
> 
> Implement same code as for wcdtm
> 
> 
> This addresses bug 14261.
>     https://issues.asterisk.org/jira/browse/14261
> 
> 
> Diffs
> -----
> 
>   linux/trunk/drivers/dahdi/wctdm24xxp/wctdm24xxp.h 10660 
>   linux/trunk/drivers/dahdi/wctdm24xxp/base.c 10660 
> 
> Diff: https://reviewboard.asterisk.org/r/1144/diff
> 
> 
> Testing
> -------
> 
> 13/04/12
> Tested with mwisendtype=lrev,hvac
> at 2 different phones on same FXS port, one a real neon phone, and another a led+zener phone.
> Left messages, and neon would flash as expected.
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120501/51941178/attachment.htm>