[asterisk-dev] [Code Review] Make sure ast_config_destroy is called when configs aren't supposed to stick around

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1834/#review5903
-----------------------------------------------------------

Ship it!


Looks fine to me.

- Tilghman


On March 28, 2012, 12:32 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1834/
> -----------------------------------------------------------
> 
> (Updated March 28, 2012, 12:32 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Several modules were not cleaning up their configs. Before this patch, 9 allocations in ast_config_new. After, 3. app_playback, res_calendar, chan_sip's sip_notify.conf are meant to be kept around.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/cdr/cdr_adaptive_odbc.c 360708 
>   /branches/1.8/channels/chan_gtalk.c 360708 
>   /branches/1.8/channels/chan_jingle.c 360708 
>   /branches/1.8/addons/cdr_mysql.c 360708 
>   /branches/1.8/addons/chan_ooh323.c 360708 
> 
> Diff: https://reviewboard.asterisk.org/r/1834/diff
> 
> 
> Testing
> -------
> 
> memory show summary config.c before and after.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120328/74e54b22/attachment.htm>