[asterisk-dev] [Code Review] Make sure ast_config_destroy is called when configs aren't supposed to stick around

Terry Wilson reviewboard at asterisk.org
Wed Mar 28 12:32:10 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1834/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Several modules were not cleaning up their configs. Before this patch, 9 allocations in ast_config_new. After, 3. app_playback, res_calendar, chan_sip's sip_notify.conf are meant to be kept around.


Diffs
-----

  /branches/1.8/cdr/cdr_adaptive_odbc.c 360708 
  /branches/1.8/channels/chan_gtalk.c 360708 
  /branches/1.8/channels/chan_jingle.c 360708 
  /branches/1.8/addons/cdr_mysql.c 360708 
  /branches/1.8/addons/chan_ooh323.c 360708 

Diff: https://reviewboard.asterisk.org/r/1834/diff


Testing
-------

memory show summary config.c before and after.


Thanks,

Terry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120328/9b51059e/attachment.htm>


More information about the asterisk-dev mailing list