[asterisk-dev] [Code Review] Add missing connected line macro calls to initial dial.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1817/#review5816
-----------------------------------------------------------

Ship it!


- Mark


On March 14, 2012, 1:46 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1817/
> -----------------------------------------------------------
> 
> (Updated March 14, 2012, 1:46 p.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Summary
> -------
> 
> The connected line interception macros do not get executed when the called channel is initially created and that channel's caller-id is implicitly imported into the incoming channel's connected line data.  If you are using the interception macros, you would expect that they get run for every change to the channel's connected line information.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_dial.c 359366 
>   /branches/1.8/apps/app_queue.c 359366 
> 
> Diff: https://reviewboard.asterisk.org/r/1817/diff
> 
> 
> Testing
> -------
> 
> The interception macros now get run on the incoming channel for the initial caller-id information of the outgoing channel.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120315/4405dd14/attachment-0001.htm>