[asterisk-dev] [Code Review]: Opaquify some ast_channel typedefs, file descriptor arrays, and the _softhangup flag

[Terry Wilson]

On March 1, 2012, 12:05 a.m., Terry Wilson wrote:
> > Apart from the above, it appears there's only a single use for softhangup_internal_flag_set in ast_do_masquerade (line 6651 of channel.c). While I appreciate it's a bit off topic for your patch, does anyone actually see a reason for removing all of the _softhangup flags before setting it to AST_SOFTHANGUP_DEV? If not, this could be changed to flag_add and flag_set be removed.

The softhangup flag in general is a big mess. Nothing is supposed to set it directly, but everything does and you can't use the existing setter function without breaking things. There is a lot of stuff that needs to happen with that code. And yes. That should definitely just be an add. It might have been changed manually before I looked at that and said "hell, no...we're adding an _add() function." :-)


- Terry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1784/#review5685
-----------------------------------------------------------


On Feb. 29, 2012, 1:04 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1784/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2012, 1:04 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> More oapquification. Most of the array stuff was done manually. So look carefully.
> 
> 
> Diffs
> -----
> 
>   /trunk/addons/chan_ooh323.c 357542 
>   /trunk/apps/app_dahdibarge.c 357542 
>   /trunk/apps/app_dahdiras.c 357542 
>   /trunk/apps/app_directed_pickup.c 357542 
>   /trunk/apps/app_dumpchan.c 357542 
>   /trunk/apps/app_flash.c 357542 
>   /trunk/apps/app_meetme.c 357542 
>   /trunk/apps/app_queue.c 357542 
>   /trunk/channels/chan_agent.c 357542 
>   /trunk/channels/chan_dahdi.c 357542 
>   /trunk/channels/chan_gtalk.c 357542 
>   /trunk/channels/chan_h323.c 357542 
>   /trunk/channels/chan_iax2.c 357542 
>   /trunk/channels/chan_jingle.c 357542 
>   /trunk/channels/chan_mgcp.c 357542 
>   /trunk/channels/chan_misdn.c 357542 
>   /trunk/channels/chan_phone.c 357542 
>   /trunk/channels/chan_sip.c 357542 
>   /trunk/channels/chan_skinny.c 357542 
>   /trunk/channels/chan_unistim.c 357542 
>   /trunk/channels/chan_vpb.cc 357542 
>   /trunk/channels/console_video.c 357542 
>   /trunk/channels/sig_analog.c 357542 
>   /trunk/channels/sig_pri.c 357542 
>   /trunk/channels/sig_ss7.c 357542 
>   /trunk/funcs/func_channel.c 357542 
>   /trunk/include/asterisk/channel.h 357542 
>   /trunk/main/autoservice.c 357542 
>   /trunk/main/channel.c 357542 
>   /trunk/main/channel_internal_api.c 357542 
>   /trunk/main/cli.c 357542 
>   /trunk/main/dsp.c 357542 
>   /trunk/main/features.c 357542 
>   /trunk/main/file.c 357542 
>   /trunk/main/pbx.c 357542 
>   /trunk/res/snmp/agent.c 357542 
> 
> Diff: https://reviewboard.asterisk.org/r/1784/diff
> 
> 
> Testing
> -------
> 
> unit tests and testsuite look good.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120301/9e7aac81/attachment.htm>