<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1784/">https://reviewboard.asterisk.org/r/1784/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 1st, 2012, 12:05 a.m., <b>wedhorn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Apart from the above, it appears there's only a single use for softhangup_internal_flag_set in ast_do_masquerade (line 6651 of channel.c). While I appreciate it's a bit off topic for your patch, does anyone actually see a reason for removing all of the _softhangup flags before setting it to AST_SOFTHANGUP_DEV? If not, this could be changed to flag_add and flag_set be removed.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The softhangup flag in general is a big mess. Nothing is supposed to set it directly, but everything does and you can't use the existing setter function without breaking things. There is a lot of stuff that needs to happen with that code. And yes. That should definitely just be an add. It might have been changed manually before I looked at that and said "hell, no...we're adding an _add() function." :-)</pre>
<br />
<p>- Terry</p>
<br />
<p>On February 29th, 2012, 1:04 p.m., Terry Wilson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Terry Wilson.</div>
<p style="color: grey;"><i>Updated Feb. 29, 2012, 1:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">More oapquification. Most of the array stuff was done manually. So look carefully.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unit tests and testsuite look good.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/addons/chan_ooh323.c <span style="color: grey">(357542)</span></li>
<li>/trunk/apps/app_dahdibarge.c <span style="color: grey">(357542)</span></li>
<li>/trunk/apps/app_dahdiras.c <span style="color: grey">(357542)</span></li>
<li>/trunk/apps/app_directed_pickup.c <span style="color: grey">(357542)</span></li>
<li>/trunk/apps/app_dumpchan.c <span style="color: grey">(357542)</span></li>
<li>/trunk/apps/app_flash.c <span style="color: grey">(357542)</span></li>
<li>/trunk/apps/app_meetme.c <span style="color: grey">(357542)</span></li>
<li>/trunk/apps/app_queue.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_agent.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_dahdi.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_gtalk.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_h323.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_jingle.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_mgcp.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_misdn.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_phone.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_skinny.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_unistim.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/chan_vpb.cc <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/console_video.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/sig_analog.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/sig_pri.c <span style="color: grey">(357542)</span></li>
<li>/trunk/channels/sig_ss7.c <span style="color: grey">(357542)</span></li>
<li>/trunk/funcs/func_channel.c <span style="color: grey">(357542)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(357542)</span></li>
<li>/trunk/main/autoservice.c <span style="color: grey">(357542)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(357542)</span></li>
<li>/trunk/main/channel_internal_api.c <span style="color: grey">(357542)</span></li>
<li>/trunk/main/cli.c <span style="color: grey">(357542)</span></li>
<li>/trunk/main/dsp.c <span style="color: grey">(357542)</span></li>
<li>/trunk/main/features.c <span style="color: grey">(357542)</span></li>
<li>/trunk/main/file.c <span style="color: grey">(357542)</span></li>
<li>/trunk/main/pbx.c <span style="color: grey">(357542)</span></li>
<li>/trunk/res/snmp/agent.c <span style="color: grey">(357542)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1784/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>