[asterisk-dev] [Code Review]: Add Expires header to SIP PUBLISH responses

[gareth]

> On June 28, 2012, 11:16 a.m., Olle E Johansson wrote:
> > Are we sure that we actually send another PUBLISH before the current one expires?

This change only affects responses to PUBLISH requests. It would be up to the sending device to refresh the dialog.


- gareth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2003/#review6598
-----------------------------------------------------------


On June 25, 2012, 10:50 p.m., gareth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2003/
> -----------------------------------------------------------
> 
> (Updated June 25, 2012, 10:50 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Successful (ie: 200 OK) responses to SIP PUBLISH requests need to have an Expires header as per RFC 3903 section 6.6.
> 
> This patch adds SIP_PUBLISH to the list of methods that need an Expires header added in respprep().
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 369389 
> 
> Diff: https://reviewboard.asterisk.org/r/2003/diff
> 
> 
> Testing
> -------
> 
> It compiles.
> 
> 
> Thanks,
> 
> gareth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120628/bf91f57b/attachment.htm>