[asterisk-dev] [Code Review] Add Expires header to SIP PUBLISH responses

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2003/#review6598
-----------------------------------------------------------


Are we sure that we actually send another PUBLISH before the current one expires?

- Olle E


On June 25, 2012, 10:50 p.m., gareth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2003/
> -----------------------------------------------------------
> 
> (Updated June 25, 2012, 10:50 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Successful (ie: 200 OK) responses to SIP PUBLISH requests need to have an Expires header as per RFC 3903 section 6.6.
> 
> This patch adds SIP_PUBLISH to the list of methods that need an Expires header added in respprep().
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 369389 
> 
> Diff: https://reviewboard.asterisk.org/r/2003/diff
> 
> 
> Testing
> -------
> 
> It compiles.
> 
> 
> Thanks,
> 
> gareth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120628/8a329837/attachment-0001.htm>