[asterisk-dev] [Code Review]: Media attribute extension

[Joshua Colp]

> On June 14, 2012, 2:24 p.m., Mark Michelson wrote:
> > The only thing I think might be missing here is a compatibility callback for the format. Say for instance that Asterisk is offered an H.263 stream with attributes A, B, and C by endpoint 1. So Asterisk would in turn offer an H.263 stream to endpoint 2 with attributes A, B, and C as well. Now, say that Asterisk receives an SDP answer from endpoint 2 where only attributes A and C are present in the H.263 stream.
> > 
> > With what we have right now, I imagine we'd just send an answer to endpoint 1 with attributes A and C. However, if there were some way for the format to say that a stream with A, B, and C is compatible with a stream with only A and C, then Asterisk could respond to endpoint 1 with an answer of attributes A, B, and C. Would this be desirable?

It already exists in the existing API, yarrrrrr.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1987/#review6467
-----------------------------------------------------------


On June 12, 2012, 11:42 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1987/
> -----------------------------------------------------------
> 
> (Updated June 12, 2012, 11:42 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I've put together two small wiki pages at the following URLs:
> 
> https://wiki.asterisk.org/wiki/display/~jcolp/Additional+Media+Attributes
> https://wiki.asterisk.org/wiki/display/~jcolp/Media+Attribute+Knowledge
> 
> They describe the attributes needed to ensure pretty rockin' video calls and also to move format attribute knowledge out of chan_sip into a separate module. The framework is pretty much there, it just needs to be extended slightly.
> 
> Since these are small I don't expect that many comments.
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviewboard.asterisk.org/r/1987/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120621/4440d63a/attachment.htm>