[asterisk-dev] [Code Review]: Add chan_dahdi Who Hung Up? implementation for analog and PRI/ISDN

[opticron]

> On June 15, 2012, 12:29 p.m., rmudgett wrote:
> > trunk/channels/sig_analog.c, lines 2700-2702
> > <https://reviewboard.asterisk.org/r/1953/diff/3/?file=28930#file28930line2700>
> >
> >     Add "add length of" comment.  To document the magic numbers.

Done


> On June 15, 2012, 12:29 p.m., rmudgett wrote:
> > trunk/channels/sig_pri.c, line 1281
> > <https://reviewboard.asterisk.org/r/1953/diff/3/?file=28931#file28931line1281>
> >
> >     You are only using p to get the owner pointer.  Why not have an owner pointer instead that you assign after you get the lock.
> >

Done


> On June 15, 2012, 12:29 p.m., rmudgett wrote:
> > trunk/channels/sig_pri.c, line 6485
> > <https://reviewboard.asterisk.org/r/1953/diff/3/?file=28931#file28931line6485>
> >
> >     Initializing is unnecessary.

Fixed


> On June 15, 2012, 12:29 p.m., rmudgett wrote:
> > trunk/channels/sig_pri.c, line 6782
> > <https://reviewboard.asterisk.org/r/1953/diff/3/?file=28931#file28931line6782>
> >
> >     Initializing this is unnecessary.

Fixed


> On June 15, 2012, 12:29 p.m., rmudgett wrote:
> > trunk/channels/sig_pri.c, line 6935
> > <https://reviewboard.asterisk.org/r/1953/diff/3/?file=28931#file28931line6935>
> >
> >     Initializing is unnecessary.

Fixed


> On June 15, 2012, 12:29 p.m., rmudgett wrote:
> > trunk/channels/sig_pri.c, lines 6497-6498
> > <https://reviewboard.asterisk.org/r/1953/diff/3/?file=28931#file28931line6497>
> >
> >     Revert this change.

Fixed


> On June 15, 2012, 12:29 p.m., rmudgett wrote:
> > trunk/channels/sig_pri.c, lines 7286-7291
> > <https://reviewboard.asterisk.org/r/1953/diff/3/?file=28931#file28931line7286>
> >
> >     pri_event2str() is in libpri so you cannot depend upon it for strings that you are hacking like this.

What do you mean?  The string is not being modified.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1953/#review6490
-----------------------------------------------------------


On June 18, 2012, 9:22 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1953/
> -----------------------------------------------------------
> 
> (Updated June 18, 2012, 9:22 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds Who Hung Up? implementations for analog (not all that useful) and PRI/ISDN DAHDI technologies.
> 
> 
> This addresses bug SWP-4222.
>     https://issues.asterisk.org/jira/browse/SWP-4222
> 
> 
> Diffs
> -----
> 
>   trunk/channels/sig_analog.c 369042 
>   trunk/channels/sig_pri.c 369042 
> 
> Diff: https://reviewboard.asterisk.org/r/1953/diff
> 
> 
> Testing
> -------
> 
> Ran calls through analog and PRI/ISDN to ensure that cause codes were showing up where expected and that the HANGUPCAUSE hash was being updated as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120618/85cb950e/attachment-0001.htm>