[asterisk-dev] [Code Review] Add chan_dahdi Who Hung Up? implementation for analog and PRI/ISDN

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1953/#review6490
-----------------------------------------------------------



trunk/channels/sig_analog.c
<https://reviewboard.asterisk.org/r/1953/#comment12273>

    Add "add length of" comment.  To document the magic numbers.



trunk/channels/sig_pri.c
<https://reviewboard.asterisk.org/r/1953/#comment12267>

    You are only using p to get the owner pointer.  Why not have an owner pointer instead that you assign after you get the lock.
    



trunk/channels/sig_pri.c
<https://reviewboard.asterisk.org/r/1953/#comment12269>

    Initializing is unnecessary.



trunk/channels/sig_pri.c
<https://reviewboard.asterisk.org/r/1953/#comment12270>

    Revert this change.



trunk/channels/sig_pri.c
<https://reviewboard.asterisk.org/r/1953/#comment12271>

    Initializing this is unnecessary.



trunk/channels/sig_pri.c
<https://reviewboard.asterisk.org/r/1953/#comment12272>

    Initializing is unnecessary.



trunk/channels/sig_pri.c
<https://reviewboard.asterisk.org/r/1953/#comment12274>

    pri_event2str() is in libpri so you cannot depend upon it for strings that you are hacking like this.


- rmudgett


On June 15, 2012, 10:41 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1953/
> -----------------------------------------------------------
> 
> (Updated June 15, 2012, 10:41 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds Who Hung Up? implementations for analog (not all that useful) and PRI/ISDN DAHDI technologies.
> 
> 
> This addresses bug SWP-4222.
>     https://issues.asterisk.org/jira/browse/SWP-4222
> 
> 
> Diffs
> -----
> 
>   trunk/channels/sig_analog.c 367414 
>   trunk/channels/sig_pri.c 367780 
> 
> Diff: https://reviewboard.asterisk.org/r/1953/diff
> 
> 
> Testing
> -------
> 
> Ran calls through analog and PRI/ISDN to ensure that cause codes were showing up where expected and that the HANGUPCAUSE hash was being updated as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120615/99b6c545/attachment-0001.htm>