[asterisk-dev] [Code Review]: AMI - Set channel variables with setvar= when manager user originates calls

[Olle E Johansson]

> On June 14, 2012, 4:17 p.m., Terry Wilson wrote:
> > According to the discussion at http://lists.digium.com/pipermail/asterisk-dev/2011-November/052068.html Kevin was ok with this on principle. He mentioned changing the name from "setvar" to "channelvar", but since there is already a "channelvars" option that does something completely different, it might be a good idea to just leave it as is. As soon as the other issues mentioned by mjordan in his revision 3 review are taken care, along with my comments this should be good go.

To use anything else than "setvar" would mean that we would have to change iax2.conf and sip.conf too, since they are using setvar. 

Thanks for the review, Terry.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1412/#review6469
-----------------------------------------------------------


On Sept. 21, 2011, 4:44 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1412/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2011, 4:44 a.m.)
> 
> 
> Review request for Asterisk Developers and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> When the manager originates calls, there's no way to add channel variables. THis patch adds a setvar= option in manager.conf for a specific account, much like in sip.conf
> 
> This is different form variables in the originate in that these are set on every call, regardless of settings in the manager client software. Good for usage in combination with the manager event filters.
> 
> 
> This addresses bug 18143.
>     https://issues.asterisk.org/jira/browse/18143
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 336090 
>   /trunk/Makefile 336090 
>   /trunk/configs/manager.conf.sample 336090 
>   /trunk/include/asterisk/config.h 336090 
>   /trunk/main/config.c 336090 
>   /trunk/main/manager.c 336090 
> 
> Diff: https://reviewboard.asterisk.org/r/1412/diff
> 
> 
> Testing
> -------
> 
> In-house testing while developing. Channel variables added (proved by dumpchan() )
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120615/03247097/attachment.htm>