[asterisk-dev] [Code Review] live_ast: don't set working directory in wrapper script 'asterisk'

Tzafrir Cohen reviewboard at asterisk.org
Thu Jul 12 18:58:42 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2027/
-----------------------------------------------------------

(Updated July 12, 2012, 6:58 p.m.)


Review request for Asterisk Developers.


Changes
-------

Fix indentation


Summary
-------

contrib/scripts/live_ast currently assumes that it is being run from the top-level directory of the source tree. It creates a script that will also set the working directory.

This fix avoids the need to set the working directory if the caller sets LIVE_AST_BASE_DIR instead.

It relies on realpath for that. If realpath is not available, it will fall back to the original behaviour.


Diffs (updated)
-----

  /trunk/contrib/scripts/live_ast 370043 

Diff: https://reviewboard.asterisk.org/r/2027/diff


Testing
-------


Thanks,

Tzafrir

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120712/91bb8979/attachment.htm>


More information about the asterisk-dev mailing list