[asterisk-dev] [Code Review] live_ast: don't set working directory in wrapper script 'asterisk'

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2027/#review6676
-----------------------------------------------------------

Ship it!



/trunk/contrib/scripts/live_ast
<https://reviewboard.asterisk.org/r/2027/#comment12665>

    incorrect alignment?


- Paul


On July 10, 2012, 8:40 a.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2027/
> -----------------------------------------------------------
> 
> (Updated July 10, 2012, 8:40 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> contrib/scripts/live_ast currently assumes that it is being run from the top-level directory of the source tree. It creates a script that will also set the working directory.
> 
> This fix avoids the need to set the working directory if the caller sets LIVE_AST_BASE_DIR instead.
> 
> It relies on realpath for that. If realpath is not available, it will fall back to the original behaviour.
> 
> 
> Diffs
> -----
> 
>   /trunk/contrib/scripts/live_ast 360137 
> 
> Diff: https://reviewboard.asterisk.org/r/2027/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120712/7b6626e0/attachment.htm>