[asterisk-dev] [Code Review]: SDP Media Attribute Interface + H.263/H.264 Format Attribute Modules

[Paul Belanger]

On 12-07-02 01:26 PM, Joshua Colp wrote:
>
>
>> On June 27, 2012, 11:19 a.m., Mark Michelson wrote:
>>> I'm giving a "ship it" due to the testing you said you've done. I'd feel better if there were unit tests added to ensure that SDP is parsed and generated properly.
>>
>> Paul Belanger wrote:
>>      Agreed, I think also adding unit tests before 'ship it' would be acceptable here.
>
> Unit tests are a separate issue, but I wanted to get eyes on this before going down that road.
>
Why separate?  Trying to understand why we as a project don't focus more 
on unit tests first before writing code and merging it.

Is it a time thing or just too much work getting a box setup for unit 
tests?  Also, do people see value in having our code review tool run 
'tests' before said patch is merged into svn?

-- 
Paul Belanger | PolyBeacon, Inc.
Jabber: paul.belanger at polybeacon.com | IRC: pabelanger (Freenode)
Github: https://github.com/pabelanger | Twitter: 
https://twitter.com/pabelanger