[asterisk-dev] [Code Review]: CEL cel_odbc backend fails to insert eventtype into integer or other numeric column

[Terry Wilson]

> On April 15, 2011, 2:35 a.m., Tilghman Lesher wrote:
> > /trunk/cel/cel_odbc.c, line 578
> > <https://reviewboard.asterisk.org/r/1160/diff/4/?file=16057#file16057line578>
> >
> >     Let's go ahead and fix this line with respect to ->allowleapsec.

Just poking on this issue to see what else needs to be done to get it committed.


- Terry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1160/#review3372
-----------------------------------------------------------


On April 5, 2011, 6:14 p.m., kkm wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1160/
> -----------------------------------------------------------
> 
> (Updated April 5, 2011, 6:14 p.m.)
> 
> 
> Review request for Asterisk Developers and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> If eventtype is numeric in the database, it gets set to NULL, not to one of the numeric values as documented in cel_odbc.conf.sample.
> 
> 
> This addresses bug 18964.
>     https://issues.asterisk.org/jira/browse/18964
> 
> 
> Diffs
> -----
> 
>   /trunk/cel/cel_odbc.c 312554 
>   /trunk/configs/cel_odbc.conf.sample 312554 
> 
> Diff: https://reviewboard.asterisk.org/r/1160/diff
> 
> 
> Testing
> -------
> 
> After preproduction testing, the change deployed to large scale production since March, 21.
> 
> 
> Thanks,
> 
> kkm
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120131/d4dde6e8/attachment.htm>