<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1160/">https://reviewboard.asterisk.org/r/1160/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 15th, 2011, 2:35 a.m., <b>Tilghman Lesher</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1160/diff/4/?file=16057#file16057line578" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/cel/cel_odbc.c</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static void odbc_log(const struct ast_event *event, void *userdata)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">534</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">((</span><span class="n">count</span> <span class="o">!=</span> <span class="mi">2</span> <span class="o">&&</span> <span class="n">count</span> <span class="o">!=</span> <span class="mi">3</span><span class="p">)</span> <span class="o">||</span> <span class="n">hour</span> <span class="o"><</span> <span class="mi">0</span> <span class="o">||</span> <span class="n">hour</span> <span class="o">></span> <span class="mi">23</span> <span class="o">||</span> <span class="n">minute</span> <span class="o"><</span> <span class="mi">0</span> <span class="o">||</span> <span class="n">minute</span> <span class="o">></span> <span class="mi">59</span> <span class="o">||</span> <span class="n">second</span> <span class="o"><</span> <span class="mi">0</span> <span class="o">||</span> <span class="n">second</span> <span class="o">></span> <span class="mi">59</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">573</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">((</span><span class="n">count</span> <span class="o">!=</span> <span class="mi">2</span> <span class="o">&&</span> <span class="n">count</span> <span class="o">!=</span> <span class="mi">3</span><span class="p">)</span> <span class="o">||</span> <span class="n">hour</span> <span class="o"><</span> <span class="mi">0</span> <span class="o">||</span> <span class="n">hour</span> <span class="o">></span> <span class="mi">23</span> <span class="o">||</span> <span class="n">minute</span> <span class="o"><</span> <span class="mi">0</span> <span class="o">||</span> <span class="n">minute</span> <span class="o">></span> <span class="mi">59</span> <span class="o">||</span> <span class="n">second</span> <span class="o"><</span> <span class="mi">0</span> <span class="o">||</span> <span class="n">second</span> <span class="o">></span> <span class="mi">59</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let's go ahead and fix this line with respect to ->allowleapsec.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just poking on this issue to see what else needs to be done to get it committed.</pre>
<br />
<p>- Terry</p>
<br />
<p>On April 5th, 2011, 6:14 p.m., kkm wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Tilghman Lesher.</div>
<div>By kkm.</div>
<p style="color: grey;"><i>Updated April 5, 2011, 6:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If eventtype is numeric in the database, it gets set to NULL, not to one of the numeric values as documented in cel_odbc.conf.sample.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After preproduction testing, the change deployed to large scale production since March, 21.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/18964">18964</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/cel/cel_odbc.c <span style="color: grey">(312554)</span></li>
<li>/trunk/configs/cel_odbc.conf.sample <span style="color: grey">(312554)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1160/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>