[asterisk-dev] [Code Review] Remove inconsistency in CEL eventtype for user defined events.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1669/#review5362
-----------------------------------------------------------

Ship it!


I can't really find any faults with what you've done, and if it solves the problem, then so be it!


/trunk/cel/cel_manager.c
<https://reviewboard.asterisk.org/r/1669/#comment9906>

    Why make this change? Unless we're specifically checking for newenablecel to be set to "1" then this is unnecessary.



/trunk/cel/cel_odbc.c
<https://reviewboard.asterisk.org/r/1669/#comment9907>

    Another case where the "? 1 : 0" just isn't necessary.



/trunk/cel/cel_odbc.c
<https://reviewboard.asterisk.org/r/1669/#comment9908>

    Similarly, no need for the empty else.



/trunk/cel/cel_pgsql.c
<https://reviewboard.asterisk.org/r/1669/#comment9909>

    And another unnecessary "? 1 : 0"


- Mark


On Jan. 13, 2012, 6:03 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1669/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2012, 6:03 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The CEL eventtype field for ODBC and PGSQL backends should be
> USER_DEFINED instead of the user defined event name supplied by
> the CELGenUserEvent application.  If the field is output as a
> number, the user defined name does not have a value and is always
> output as 21 for USER_DEFINED and the userdeftype field would
> be required to supply the user defined name.
> 
> This patch also allows cel_manager, cel_custom, and
> cel_sqlite3_custom to behave the same way.
> 
> The following CEL backends (cel_odbc, cel_pgsql, cel_custom,
> cel_manager, and cel_sqlite3_custom) can be independently configured
> to remove this inconsistency.
> 
> 
> This addresses bug ASTERISK-17189.
>     https://issues.asterisk.org/jira/browse/ASTERISK-17189
> 
> 
> Diffs
> -----
> 
>   /trunk/cel/cel_manager.c 350785 
>   /trunk/cel/cel_odbc.c 350785 
>   /trunk/cel/cel_pgsql.c 350785 
>   /trunk/cel/cel_tds.c 350785 
>   /trunk/configs/cel.conf.sample 350785 
>   /trunk/configs/cel_custom.conf.sample 350785 
>   /trunk/configs/cel_odbc.conf.sample 350785 
>   /trunk/configs/cel_pgsql.conf.sample 350785 
>   /trunk/configs/cel_sqlite3_custom.conf.sample 350785 
>   /trunk/main/cel.c 350785 
> 
> Diff: https://reviewboard.asterisk.org/r/1669/diff
> 
> 
> Testing
> -------
> 
> It compiles. :)
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120131/0164bea5/attachment-0001.htm>