[asterisk-dev] [Code Review] Remove inconsistency in CEL eventtype for user defined events.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1669/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

The CEL eventtype field for ODBC and PGSQL backends should be
USER_DEFINED instead of the user defined event name supplied by
the CELGenUserEvent application.  If the field is output as a
number, the user defined name does not have a value and is always
output as 21 for USER_DEFINED and the userdeftype field would
be required to supply the user defined name.

This patch also allows cel_manager, cel_custom, and
cel_sqlite3_custom to behave the same way.

The following CEL backends (cel_odbc, cel_pgsql, cel_custom,
cel_manager, and cel_sqlite3_custom) can be independently configured
to remove this inconsistency.


This addresses bug ASTERISK-17189.
    https://issues.asterisk.org/jira/browse/ASTERISK-17189


Diffs
-----

  /trunk/cel/cel_manager.c 350785 
  /trunk/cel/cel_odbc.c 350785 
  /trunk/cel/cel_pgsql.c 350785 
  /trunk/cel/cel_tds.c 350785 
  /trunk/configs/cel.conf.sample 350785 
  /trunk/configs/cel_custom.conf.sample 350785 
  /trunk/configs/cel_odbc.conf.sample 350785 
  /trunk/configs/cel_pgsql.conf.sample 350785 
  /trunk/configs/cel_sqlite3_custom.conf.sample 350785 
  /trunk/main/cel.c 350785 

Diff: https://reviewboard.asterisk.org/r/1669/diff


Testing
-------

It compiles. :)


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120114/ef12e803/attachment.htm>