[asterisk-dev] [Code Review] Add channel locking around datastore accesses in func_odbc.c.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1687/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Accessing the channel datastore list without first locking the channel is bad.

Adds missing locking around the channel datastore accesses in func_odbc.c.

* Fixed a potential memory leak when an existing datastore is manually destroyed by inline code instead of calling ast_datastore_free().


This addresses bug ASTERISK-17948.
    https://issues.asterisk.org/jira/browse/ASTERISK-17948


Diffs
-----

  /branches/1.8/funcs/func_odbc.c 352199 

Diff: https://reviewboard.asterisk.org/r/1687/diff


Testing
-------

It compiles. :)


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120123/0796c2cb/attachment.htm>