[asterisk-dev] [Code Review] Remove chan_usbradio and app_rpt.

[Steve Totaro]

On Tue, Feb 28, 2012 at 9:42 AM, Leif Madsen <reviewboard at asterisk.org>
 wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1764/
>
> This patch set needs UPGRADE.txt and CHANGES updated to reflect that these modules have been removed, and ideally, a pointer to where the maintained code lives. For 1.8 and 10 of course you'll need to add a header about changes between 1.8.x and 1.8.x+1 (obviously same for 10.x).
>
>
> - Leif
>
> On February 22nd, 2012, 10:01 a.m., Russell Bryant wrote:
> Review request for Asterisk Developers.
> By Russell Bryant.
>
> *Updated Feb. 22, 2012, 10:01 a.m.*
> Description
>
> This patch removes app_rpt and chan_usbradio from trunk.  I don't have a problem at all with these modules being in trunk, but they do not appear to be maintained in this repository.  One of the primary radio guys said in #asterisk-dev the other day that plenty of people use this stuff, but that fixes haven't been sent back up to this repo in years.  It seems harmful to have an out-of-date copy of this code here.
>
> Testing
>
> ran configure and make.
>
> Diffs
>
>    - /trunk/apps/app_rpt.c (356258)
>    - /trunk/build_tools/menuselect-deps.in (356258)
>    - /trunk/channels/chan_usbradio.c (356258)
>    - /trunk/channels/xpmr/sinetabx.h (356258)
>    - /trunk/channels/xpmr/xpmr.h (356258)
>    - /trunk/channels/xpmr/xpmr.c (356258)
>    - /trunk/channels/xpmr/xpmr_coef.h (356258)
>    - /trunk/configure (UNKNOWN)
>    - /trunk/configure.ac (356258)
>    - /trunk/include/asterisk/autoconfig.h.in (356258)
>    - /trunk/makeopts.in (356258)
>
> View Diff <https://reviewboard.asterisk.org/r/1764/diff/>
>
> --


On Tue, Feb 28, 2012 at 3:35 PM, Steve Totaro
<stotaro at asteriskhelpdesk.com>wrote:

> Please allow me a few days to get this sorted out.
>
> I know why it is not being maintained in the respository, part is
> political, part is business motivated.
>
> It goes against the grain of all that is Asterisk and I am in a position
> to make a real issue of it in this "divergent" community.
>
> I ask for a week to convince the maintainers that letting this happen is a
> really bad idea, and it is, so the community will back me.
>
> Thanks,
> Steve Totaro
> KB3OPB
>

I argued quite a bit about this point.  I found this from 03/06/2009, the
mailing list has changed many times.  I am trying to track down the current
list.  The QRVC hosted list bounced.

It was at one point hosted by QRVC who sells a devices for app_rpt.

Here is a snippet from a thread about the issue on mailing list back in
2009.  The snippet is in answer to a question of who maintains the code and
where to get it.  Pure BS IMO.

My exchanges and downright protests were direct with devs, not on the list,
so I will have to dig some more.

"Unfortunately, things are in somewhat of a mess.

There are major logistical hurdles with getting app_rpt code back into
the main Digium source tree. In addition, the latest versions of
asterisk have broken some of the code which app_rpt.c depends on, The
best thing to do at this point in time is to download the files.tar.gz
patched version of Asterisk from http://dl.allstarlink.org/installcd
and unpack it in /usr/src. Configure and compile zaptel, libpri, and
asterisk just like you would be downloading the sources from asterisk.org.

Once you have this version running, you can download the latest
app_rpt.c from:

http://svn.digium.com/view/asterisk/team/jdixon/chan_usbradio-1.4/apps

and install it in /usr/src/asterisk/apps and recompile asterisk."

73,
Steve Totaro
KB30PB
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120228/24e87214/attachment.htm>