<br class="Apple-interchange-newline"><br><div class="gmail_quote"><div><div class="h5">On Tue, Feb 28, 2012 at 9:42 AM, Leif Madsen <span dir="ltr"><<a href="mailto:reviewboard@asterisk.org" target="_blank">reviewboard@asterisk.org</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div>
<div class="h5"><div><div style="font-family:Verdana,Arial,Helvetica,sans-serif"><div><table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border-top-width:1px;border-right-width:1px;border-bottom-width:1px;border-left-width:1px;border-top-color:rgb(201,195,153);border-right-color:rgb(201,195,153);border-bottom-color:rgb(201,195,153);border-left-color:rgb(201,195,153);border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid">
<tbody><tr><td>This is an automatically generated e-mail. To reply, visit: <a href="https://reviewboard.asterisk.org/r/1764/" target="_blank">https://reviewboard.asterisk.org/r/1764/</a></td></tr></tbody></table><br></div>
<pre style="white-space:pre-wrap;word-wrap:break-word">This patch set needs UPGRADE.txt and CHANGES updated to reflect that these modules have been removed, and ideally, a pointer to where the maintained code lives. For 1.8 and 10 of course you'll need to add a header about changes between 1.8.x and 1.8.x+1 (obviously same for 10.x).</pre>
<br><p>- Leif</p><div><br><p>On February 22nd, 2012, 10:01 a.m., Russell Bryant wrote:</p></div><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style><tbody><tr><td><div><div>Review request for Asterisk Developers.</div>
<div>By Russell Bryant.</div></div><p style="color:grey"><i>Updated Feb. 22, 2012, 10:01 a.m.</i></p><h1 style="color:rgb(87,80,18);font-size:10pt;margin-top:1.5em">Description</h1><div><table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border-top-width:1px;border-right-width:1px;border-bottom-width:1px;border-left-width:1px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(184,181,160);border-right-color:rgb(184,181,160);border-bottom-color:rgb(184,181,160);border-left-color:rgb(184,181,160)">
<tbody><tr><td><pre style="margin-top:0px;margin-bottom:0px;padding-top:0px;padding-right:0px;padding-bottom:0px;padding-left:0px;white-space:pre-wrap;word-wrap:break-word">This patch removes app_rpt and chan_usbradio from trunk. I don't have a problem at all with these modules being in trunk, but they do not appear to be maintained in this repository. One of the primary radio guys said in #asterisk-dev the other day that plenty of people use this stuff, but that fixes haven't been sent back up to this repo in years. It seems harmful to have an out-of-date copy of this code here.</pre>
</td></tr></tbody></table><h1 style="color:rgb(87,80,18);font-size:10pt;margin-top:1.5em">Testing</h1><table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border-top-width:1px;border-right-width:1px;border-bottom-width:1px;border-left-width:1px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(184,181,160);border-right-color:rgb(184,181,160);border-bottom-color:rgb(184,181,160);border-left-color:rgb(184,181,160)">
<tbody><tr><td><pre style="margin-top:0px;margin-bottom:0px;padding-top:0px;padding-right:0px;padding-bottom:0px;padding-left:0px;white-space:pre-wrap;word-wrap:break-word">ran configure and make.</pre></td></tr></tbody></table>
<h1 style="color:rgb(87,80,18);font-size:10pt;margin-top:1.5em">Diffs</h1><ul style="margin-left:3em;padding-left:0px"><li>/trunk/apps/app_rpt.c <span style="color:grey">(356258)</span></li><li>/trunk/build_tools/<a href="http://menuselect-deps.in/" target="_blank">menuselect-deps.in</a> <span style="color:grey">(356258)</span></li>
<li>/trunk/channels/chan_usbradio.c <span style="color:grey">(356258)</span></li><li>/trunk/channels/xpmr/sinetabx.h <span style="color:grey">(356258)</span></li><li>/trunk/channels/xpmr/xpmr.h <span style="color:grey">(356258)</span></li>
<li>/trunk/channels/xpmr/xpmr.c <span style="color:grey">(356258)</span></li><li>/trunk/channels/xpmr/xpmr_coef.h <span style="color:grey">(356258)</span></li><li>/trunk/configure <span style="color:grey">(UNKNOWN)</span></li>
<li>/trunk/<a href="http://configure.ac/" target="_blank">configure.ac</a> <span style="color:grey">(356258)</span></li><li>/trunk/include/asterisk/<a href="http://autoconfig.h.in/" target="_blank">autoconfig.h.in</a> <span style="color:grey">(356258)</span></li>
<li>/trunk/<a href="http://makeopts.in/" target="_blank">makeopts.in</a> <span style="color:grey">(356258)</span></li></ul><p><a href="https://reviewboard.asterisk.org/r/1764/diff/" target="_blank" style="margin-left:3em">View Diff</a></p>
</div></td></tr></tbody></table></div></div><br></div></div><span class="HOEnZb"><font color="#888888">--</font></span></blockquote></div><br><div class="gmail_quote">On Tue, Feb 28, 2012 at 3:35 PM, Steve Totaro <span dir="ltr"><<a href="mailto:stotaro@asteriskhelpdesk.com">stotaro@asteriskhelpdesk.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Please allow me a few days to get this sorted out.<div><br></div><div>I know why it is not being maintained in the respository, part is political, part is business motivated.</div>
<div><br></div><div>It goes against the grain of all that is Asterisk and I am in a position to make a real issue of it in this "divergent" community.</div>
<div><br></div><div>I ask for a week to convince the maintainers that letting this happen is a really bad idea, and it is, so the community will back me.</div><div><br></div><div>Thanks,</div><div>Steve Totaro</div><div>
KB3OPB<br></div></blockquote><div><br></div><div><span style>I argued quite a bit about this point. I found this from 03/06/2009, the mailing list has changed many times. I am trying to track down the current list. The QRVC hosted list bounced.</span></div>
<div style><br></div><div style>It was at one point hosted by QRVC who sells a devices for app_rpt.</div><div style><br></div><div style>Here is a snippet from a thread about the issue on mailing list back in 2009. The snippet is in answer to a question of who maintains the code and where to get it. Pure BS IMO.<br>
</div><div style><br></div><div style>My exchanges and downright protests were direct with devs, not on the list, so I will have to dig some more.</div><div style><br></div><div style>"Unfortunately, things are in somewhat of a mess.</div>
<br style><span style>There are major logistical hurdles with getting app_rpt code back into</span><br style><span style>the main Digium source tree. In addition, the latest versions of</span><br style><span style>asterisk have broken some of the code which app_rpt.c depends on, The</span><br style>
<span style>best thing to do at this point in time is to download the files.tar.gz</span><br style><span style>patched version of Asterisk from </span><a href="http://dl.allstarlink.org/installcd" target="_blank" style>http://dl.allstarlink.org/installcd</a><br style>
<span style>and unpack it in /usr/src. Configure and compile zaptel, libpri, and</span><br style><span style>asterisk just like you would be downloading the sources from </span><a href="http://asterisk.org/" target="_blank" style>asterisk.org</a><span style>.</span><br style>
<br style><span style>Once you have this version running, you can download the latest</span><br style><span style>app_rpt.c from:</span><br style><br style><a href="http://svn.digium.com/view/asterisk/team/jdixon/chan_usbradio-1.4/apps" target="_blank" style>http://svn.digium.com/view/asterisk/team/jdixon/chan_usbradio-1.4/apps</a><br style>
<br style><span style>and install it in /usr/src/asterisk/apps and recompile asterisk."</span><br style><div style><br></div><div style>73,</div><div style>Steve Totaro</div><div style>KB30PB</div></div>