[asterisk-dev] [Code Review] Remove chan_usbradio and app_rpt.

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1764/#review5665
-----------------------------------------------------------


I'd like to change the scope of this patch from just trunk to be all currently supported branches: 1.8, 10, and trunk.  Since these modules are maintained and distributed from elsewhere, it seems potentially harmful to leave them in Asterisk.  We want people to get the code from the right place.

- Russell


On Feb. 22, 2012, 10:01 a.m., Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1764/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2012, 10:01 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch removes app_rpt and chan_usbradio from trunk.  I don't have a problem at all with these modules being in trunk, but they do not appear to be maintained in this repository.  One of the primary radio guys said in #asterisk-dev the other day that plenty of people use this stuff, but that fixes haven't been sent back up to this repo in years.  It seems harmful to have an out-of-date copy of this code here.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_rpt.c 356258 
>   /trunk/build_tools/menuselect-deps.in 356258 
>   /trunk/channels/chan_usbradio.c 356258 
>   /trunk/channels/xpmr/sinetabx.h 356258 
>   /trunk/channels/xpmr/xpmr.h 356258 
>   /trunk/channels/xpmr/xpmr.c 356258 
>   /trunk/channels/xpmr/xpmr_coef.h 356258 
>   /trunk/configure UNKNOWN 
>   /trunk/configure.ac 356258 
>   /trunk/include/asterisk/autoconfig.h.in 356258 
>   /trunk/makeopts.in 356258 
> 
> Diff: https://reviewboard.asterisk.org/r/1764/diff
> 
> 
> Testing
> -------
> 
> ran configure and make.
> 
> 
> Thanks,
> 
> Russell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120228/6885065a/attachment.htm>