<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1764/">https://reviewboard.asterisk.org/r/1764/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd like to change the scope of this patch from just trunk to be all currently supported branches: 1.8, 10, and trunk. Since these modules are maintained and distributed from elsewhere, it seems potentially harmful to leave them in Asterisk. We want people to get the code from the right place.</pre>
<br />
<p>- Russell</p>
<br />
<p>On February 22nd, 2012, 10:01 a.m., Russell Bryant wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Russell Bryant.</div>
<p style="color: grey;"><i>Updated Feb. 22, 2012, 10:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch removes app_rpt and chan_usbradio from trunk. I don't have a problem at all with these modules being in trunk, but they do not appear to be maintained in this repository. One of the primary radio guys said in #asterisk-dev the other day that plenty of people use this stuff, but that fixes haven't been sent back up to this repo in years. It seems harmful to have an out-of-date copy of this code here.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ran configure and make.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/app_rpt.c <span style="color: grey">(356258)</span></li>
<li>/trunk/build_tools/menuselect-deps.in <span style="color: grey">(356258)</span></li>
<li>/trunk/channels/chan_usbradio.c <span style="color: grey">(356258)</span></li>
<li>/trunk/channels/xpmr/sinetabx.h <span style="color: grey">(356258)</span></li>
<li>/trunk/channels/xpmr/xpmr.h <span style="color: grey">(356258)</span></li>
<li>/trunk/channels/xpmr/xpmr.c <span style="color: grey">(356258)</span></li>
<li>/trunk/channels/xpmr/xpmr_coef.h <span style="color: grey">(356258)</span></li>
<li>/trunk/configure <span style="color: grey">(UNKNOWN)</span></li>
<li>/trunk/configure.ac <span style="color: grey">(356258)</span></li>
<li>/trunk/include/asterisk/autoconfig.h.in <span style="color: grey">(356258)</span></li>
<li>/trunk/makeopts.in <span style="color: grey">(356258)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1764/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>